| Summary: | Web Inspector: preload status bar button glyphs in order to prevent them from flickering. | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Pavel Feldman <pfeldman> | ||||||
| Component: | Web Inspector (Deprecated) | Assignee: | Pavel Feldman <pfeldman> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | bweinstein, joepeck, rik, timothy | ||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | All | ||||||||
| OS: | All | ||||||||
| Attachments: |
|
||||||||
|
Description
Pavel Feldman
2009-11-12 14:17:27 PST
Created attachment 43098 [details]
[PATCH] proposed fix
Comment on attachment 43098 [details]
[PATCH] proposed fix
I prefer preloading from JS doing:
(new Image()).src = "Images/clearConsoleButtonGlyph.png";
That way the DOM isn't involved and polluted.
Created attachment 43104 [details]
[PATCH] addressed comments
Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebCore/ChangeLog M WebCore/inspector/front-end/inspector.js Committed r50908 I had to revert this due to tests timing out. Need to find a way of telling frontend that it is within tests, that way it would be able to skip this step. Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebCore/ChangeLog M WebCore/inspector/front-end/inspector.js Committed r50935 How did this cause a timeout? (In reply to comment #6) > How did this cause a timeout? I am not sure, I noticed Tiger being flaky after that commit. It did not stop being so after I rolled back though. So re-applying. Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebCore/ChangeLog M WebCore/inspector/front-end/inspector.js Committed r50947 |