Bug 31439

Summary: Web Inspector: preload status bar button glyphs in order to prevent them from flickering.
Product: WebKit Reporter: Pavel Feldman <pfeldman>
Component: Web Inspector (Deprecated)Assignee: Pavel Feldman <pfeldman>
Status: RESOLVED FIXED    
Severity: Normal CC: bweinstein, joepeck, rik, timothy
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
[PATCH] proposed fix
timothy: review-
[PATCH] addressed comments none

Pavel Feldman
Reported 2009-11-12 14:17:27 PST
I am going to put them into inspector.html.
Attachments
[PATCH] proposed fix (2.23 KB, patch)
2009-11-12 14:19 PST, Pavel Feldman 		timothy: review-
DetailsFormatted DiffDiff
[PATCH] addressed comments (1.85 KB, patch)
2009-11-12 15:00 PST, Pavel Feldman 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Pavel Feldman
Comment 1 2009-11-12 14:19:17 PST
Created attachment 43098 [details] [PATCH] proposed fix
Timothy Hatcher
Comment 2 2009-11-12 14:46:36 PST
Comment on attachment 43098 [details] [PATCH] proposed fix I prefer preloading from JS doing: (new Image()).src = "Images/clearConsoleButtonGlyph.png"; That way the DOM isn't involved and polluted.
Pavel Feldman
Comment 3 2009-11-12 15:00:22 PST
Created attachment 43104 [details] [PATCH] addressed comments
Pavel Feldman
Comment 4 2009-11-12 15:04:35 PST
Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebCore/ChangeLog M WebCore/inspector/front-end/inspector.js Committed r50908
Pavel Feldman
Comment 5 2009-11-13 02:46:11 PST
I had to revert this due to tests timing out. Need to find a way of telling frontend that it is within tests, that way it would be able to skip this step. Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebCore/ChangeLog M WebCore/inspector/front-end/inspector.js Committed r50935
Timothy Hatcher
Comment 6 2009-11-13 09:21:43 PST
How did this cause a timeout?
Pavel Feldman
Comment 7 2009-11-13 09:27:12 PST
(In reply to comment #6) > How did this cause a timeout? I am not sure, I noticed Tiger being flaky after that commit. It did not stop being so after I rolled back though. So re-applying. Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebCore/ChangeLog M WebCore/inspector/front-end/inspector.js Committed r50947
Note You need to log in before you can comment on or make changes to this bug.