Bug 314166
| Summary: | [submitproject] Use includes rather than excludes | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Jonathan Bedard <jbedard> |
| Component: | Tools / Tests | Assignee: | Jonathan Bedard <jbedard> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Jonathan Bedard
Excludes can easily be accidentally over-inclusive. We should use includes rather than excludes in our .submitproject. Excludes also cannot be overriden by all .submitproject processing systems, so excluding a directory prevents future expansions from including the same directory.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/176326251>
Jonathan Bedard
Pull request: https://github.com/WebKit/WebKit/pull/64336
EWS
Committed 313414@main (1a68aba71cc9): <https://commits.webkit.org/313414@main>
Reviewed commits have been landed. Closing PR #64336 and removing active labels.
EWS
Committed 305413.926@safari-7624-branch (bce6efe324df): <https://commits.webkit.org/305413.926@safari-7624-branch>
Reviewed commits have been landed. Closing PR #5306 and removing active labels.