Bug 313839
| Summary: | [CMake] Fix macOS build after 312428@main by adding rendering/cocoa to WebCore include dirs | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | zak ridouh <zakr> |
| Component: | CMake | Assignee: | zak ridouh <zakr> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
zak ridouh
Commit 312428@main ([WebCore] Fix underlying build errors hidden by
UnifiedBuild files) added a direct `#include "RenderThemeCocoa.h"` in
Source/WebCore/page/InteractionRegion.cpp, which is gated on
ENABLE(FORM_CONTROL_REFRESH). RenderThemeCocoa.h lives in
Source/WebCore/rendering/cocoa, but that directory was never part of
WebCore_PRIVATE_INCLUDE_DIRECTORIES, so the Mac CMake port fails with:
Source/WebCore/page/InteractionRegion.cpp:79:10: fatal error:
'RenderThemeCocoa.h' file not found
The Xcode build happened to find the header via its own header search
paths, so the problem only shows up in the CMake Mac port.
Add rendering/cocoa to WebCore_PRIVATE_INCLUDE_DIRECTORIES in
PlatformMac.cmake so the header resolves the same way the sibling
rendering/mac directory's headers already do (via -I from other paths).
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/176042265>
zak ridouh
Pull request: https://github.com/WebKit/WebKit/pull/64057
EWS
Committed 312448@main (077d9a850018): <https://commits.webkit.org/312448@main>
Reviewed commits have been landed. Closing PR #64057 and removing active labels.