Bug 313792
| Summary: | [EWS] clean-build doesn't remove intermediate files | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Elliott Williams <emw> |
| Component: | Tools / Tests | Assignee: | Alexey Proskuryakov <ap> |
| Status: | RESOLVED WORKSFORME | ||
| Severity: | Normal | CC: | aakash_jain, bfulgham, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=313791 | ||
Elliott Williams
The clean-build step run by buildbot is misleading. It's labeled "delete WebKitBuild directory" in the UI, but the script it runs (Tools/CISupport/clean-build) looks up the *products* directory for the current platform, and deletes that. So for example, an iOS device release builder removes:
WebKitBuild/Release-iphoneos
What it should really do is remove the intermediates, too. This could be done with a command like:
rm WebKitBuild/{,*.build/}Release-iphoneos
Or we could just delete the whole build directory like we advertise, since we do not have any multi-platform builders.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/176046546>
Alexey Proskuryakov
Pull request: https://github.com/WebKit/WebKit/pull/64064
Elliott Williams
I misjudged what this script is doing, and my report was based on bad evidence. It's actually passing --top-level to `webkit-build-directory`, so it _does_ delete the whole build dir. For example:
```
emw@aria2 ~/wk2> ls WebKitBuild
ANGLE.build/ JavaScriptCore.build/ SwiftBrowser.build/ WebKitLegacy.build/
bmalloc.build/ libwebrtc.build/ SwiftExplicitPrecompiledModules/ WebKitTestRunner.build/
dav1d.build/ lldbWebKitTester.build/ TestWebKitAPI.build/ WTF.build/
DumpRenderTree.build/ MiniBrowser.build/ WebCore.build/ XCBuildData/
EagerLinkingTBDs/ PAL.build/ WebGPU.build/
ExplicitPrecompiledModules/ PrecompiledHeaders/ WebInspectorUI.build/
gtest.build/ Release/ WebKit.build/
emw@aria2 ~/wk2> python3 Tools/CISupport/clean-build --platform=mac-tahoe --release
emw@aria2 ~/wk2> ls WebKitBuild
ls: WebKitBuild: No such file or directory
```