Bug 31371

Summary: SharedWorkerRepository.connect() does not call WebSharedWorkerRepository
Product: WebKit Reporter: Andrew Wilson <atwilson>
Component: WebCore JavaScriptAssignee: Andrew Wilson <atwilson>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Attachments:
Description Flags
proposed patch none

Description Andrew Wilson 2009-11-11 13:05:03 PST
In a recent refactoring, we changed how the chromium version of SharedWorkerRepository.connect() works, but left out a call to WebKitSharedWorkerRepository.addSharedWorker().

This causes SharedWorkers to not get shutdown properly when the document exits.
Comment 1 Andrew Wilson 2009-11-11 13:10:06 PST
Created attachment 42994 [details]
proposed patch

This is the upstreamed version of the change to SharedWorkerRepository from http://codereview.chromium.org/390017.
Comment 2 WebKit Commit Bot 2009-11-11 13:23:09 PST
Comment on attachment 42994 [details]
proposed patch

Clearing flags on attachment: 42994

Committed r50838: <http://trac.webkit.org/changeset/50838>
Comment 3 WebKit Commit Bot 2009-11-11 13:23:12 PST
All reviewed patches have been landed.  Closing bug.