Bug 31368

Summary: [V8] De-inline large method convertNodeToV8Object
Product: WebKit Reporter: Jens Alfke <jens>
Component: WebCore Misc.Assignee: Jens Alfke <jens>
Status: RESOLVED FIXED    
Severity: Enhancement    
Priority: P3    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 31217    
Attachments:
Description Flags
path fix
none
patch dglazkov: review+

Description Jens Alfke 2009-11-11 12:27:36 PST 
The method V8DOMWrapper::convertNodeToV8Object is declared as inline, and there are 136 calls to it in the generated V8 bindings. It's a fairly complex piece of code that expands to a lot of machine instructions. De-inlining it helps shrink the bindings.
Comment 1 Yaar Schnitman 2009-11-11 12:50:30 PST 
Created attachment 42991 [details]
path fix
Comment 2 Yaar Schnitman 2009-11-11 12:52:11 PST 
Comment on attachment 42991 [details]
path fix

Please ignore.
Comment 3 Jens Alfke 2009-11-11 13:02:55 PST 
Created attachment 42993 [details]
patch
Comment 4 Dimitri Glazkov (Google) 2009-11-11 13:04:24 PST 
Comment on attachment 42993 [details]
patch

awesome.
Comment 5 Jens Alfke 2009-11-11 13:10:10 PST 
Committed revision 50835.