Bug 31368

Summary:

[V8] De-inline large method convertNodeToV8Object

Product:

WebKit

Reporter:

Jens Alfke <jens>

Component:

WebCore Misc.

Assignee:

Jens Alfke <jens>

Status:

RESOLVED FIXED

Severity:

Enhancement

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Bug Depends on:

Bug Blocks:

31217

Attachments:

Description	Flags
path fix	none
patch	dglazkov: review+

Jens Alfke

Reported 2009-11-11 12:27:36 PST

The method V8DOMWrapper::convertNodeToV8Object is declared as inline, and there are 136 calls to it in the generated V8 bindings. It's a fairly complex piece of code that expands to a lot of machine instructions. De-inlining it helps shrink the bindings.

Attachments
path fix (1.49 KB, text/plain) 2009-11-11 12:50 PST, Yaar Schnitman	no flags	Details
patch (2.79 KB, patch) 2009-11-11 13:02 PST, Jens Alfke	dglazkov: review+	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Yaar Schnitman

Comment 1 2009-11-11 12:50:30 PST

Created attachment 42991 [details] path fix

Yaar Schnitman

Comment 2 2009-11-11 12:52:11 PST

Comment on attachment 42991 [details] path fix Please ignore.

Jens Alfke

Comment 3 2009-11-11 13:02:55 PST

Created attachment 42993 [details] patch

Dimitri Glazkov (Google)

Comment 4 2009-11-11 13:04:24 PST

Comment on attachment 42993 [details] patch awesome.

Jens Alfke

Comment 5 2009-11-11 13:10:10 PST

Committed revision 50835.

Note You need to log in before you can comment on or make changes to this bug.