Bug 31366

Summary: Update committers.py based on svn records
Product: WebKit Reporter: Eric Seidel (no email) <eric>
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, adele, alice.barraclough, commit-queue, levin
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Bug Depends on:    
Bug Blocks: 30970    
Attachments:
Description Flags
Patch none

Eric Seidel (no email)
Reported 2009-11-11 11:43:02 PST
Alice pointed out a couple weeks ago that committers.py was missing several committers. At the time, there was no way to validate the list against any of our other various lists to know if committers were in fact missing. Since that time I've written validate-committer-lists (attached to bug 30970) and discovered that a bunch of committers are missing. This bug is about updating committers.py to include all committers who have committed in the last few years. I've excluded committers who haven't committed in 3+ years for now, but will add them in a separate patch.
Attachments
Patch (5.84 KB, patch)
2009-11-11 11:48 PST, Eric Seidel (no email) 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Eric Seidel (no email)
Comment 1 2009-11-11 11:48:50 PST
Created attachment 42987 [details] Patch
Adam Barth
Comment 2 2009-11-12 20:54:02 PST
Comment on attachment 42987 [details] Patch I believe you.
WebKit Commit Bot
Comment 3 2009-11-12 21:17:29 PST
Comment on attachment 42987 [details] Patch Rejecting patch 42987 from commit-queue. Failed to run "['WebKitTools/Scripts/run-webkit-tests', '--no-launch-safari', '--quiet', '--exit-after-n-failures=1']" exit_code: 1 Running build-dumprendertree Running tests from /Users/eseidel/Projects/CommitQueue/LayoutTests Testing 11618 test cases. http/tests/xmlhttprequest/workers/shared-worker-close.html -> crashed Exiting early after 1 failures. 9308 tests run. 483.21s total testing time 9307 test cases (99%) succeeded 1 test case (<1%) crashed 5 test cases (<1%) had stderr output
Adam Barth
Comment 4 2009-11-12 21:42:57 PST
Comment on attachment 42987 [details] Patch Silly flaky tests
WebKit Commit Bot
Comment 5 2009-11-12 21:56:43 PST
Comment on attachment 42987 [details] Patch Rejecting patch 42987 from commit-queue. Failed to run "['WebKitTools/Scripts/run-webkit-tests', '--no-launch-safari', '--quiet', '--exit-after-n-failures=1']" exit_code: 1 Running build-dumprendertree Running tests from /Users/eseidel/Projects/CommitQueue/LayoutTests Testing 11618 test cases. http/tests/xmlhttprequest/access-control-and-redirects.html -> crashed Exiting early after 1 failures. 9149 tests run. 456.92s total testing time 9148 test cases (99%) succeeded 1 test case (<1%) crashed 5 test cases (<1%) had stderr output
Eric Seidel (no email)
Comment 6 2009-11-12 23:59:06 PST
I filed bug 31460 and bug 31461 about the failures. I expect these are just flakey tests.
WebKit Commit Bot
Comment 7 2009-11-13 00:11:52 PST
Comment on attachment 42987 [details] Patch Clearing flags on attachment: 42987 Committed r50931: <http://trac.webkit.org/changeset/50931>
WebKit Commit Bot
Comment 8 2009-11-13 00:12:00 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.