Bug 31361

Summary:

WebInspector: Tests for Layout, Paint, ParseHTML, MarkTimeline, Style Recalculation

Product:

WebKit

Reporter:

Eric Ayers <zundel>

Component:

Web Inspector (Deprecated)

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, knorton, pfeldman, timothy, zundel

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
WebInspector: Adds Timeline record tests for Layout, Paint, Recalculate Style, Parse HTML and Mark Timeline	pfeldman: review-
WebInspector: Adds another script tag test for WebInspector timeline records.	pfeldman: review+, commit-queue: commit-queue-
WebInspector: Adds Timeline record tests for Layout, Paint, Recalculate Style, Parse HTML and Mark Timeline	none

Eric Ayers

Reported 2009-11-11 10:43:17 PST

These tests are all pretty simple - they find the timeline record of interest and dump it.

Attachments
WebInspector: Adds Timeline record tests for Layout, Paint, Recalculate Style, Parse HTML and Mark Timeline (9.29 KB, patch) 2009-11-11 11:03 PST, Eric Ayers	pfeldman: review-	Details Formatted Diff Diff
WebInspector: Adds another script tag test for WebInspector timeline records. (10.37 KB, patch) 2009-11-11 11:43 PST, Eric Ayers	pfeldman: review+ commit-queue: commit-queue-	Details Formatted Diff Diff
WebInspector: Adds Timeline record tests for Layout, Paint, Recalculate Style, Parse HTML and Mark Timeline (9.28 KB, patch) 2009-11-11 12:16 PST, Eric Ayers	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Eric Ayers

Comment 1 2009-11-11 11:03:10 PST

Created attachment 42979 [details] WebInspector: Adds Timeline record tests for Layout, Paint, Recalculate Style, Parse HTML and Mark Timeline

Pavel Feldman

Comment 2 2009-11-11 11:13:33 PST

Comment on attachment 42979 [details] WebInspector: Adds Timeline record tests for Layout, Paint, Recalculate Style, Parse HTML and Mark Timeline > + if (record.type == timelineAgentRecordType.Layout) { Please use === > + if (record.type == timelineAgentRecordType.MarkTimeline && record.data.message == timelineMark) { ditto > + if (found =findMarkTimeline(record)) space after = > + if (record.type == timelineAgentRecordType.Paint) { ditto > + if (record.type == timelineAgentRecordType.ParseHTML) { ditto > + if (record.type == timelineAgentRecordType.RecalculateStyles) { ditto r- for style, rest seems to be fine.

Eric Ayers

Comment 3 2009-11-11 11:43:29 PST

Created attachment 42985 [details] WebInspector: Adds another script tag test for WebInspector timeline records. Fixes style problems noted in review feedback of previous patch.

Pavel Feldman

Comment 4 2009-11-11 11:53:59 PST

Comment on attachment 42985 [details] WebInspector: Adds another script tag test for WebInspector timeline records. =findMarkTimeline is still there, please fix with the next patch.

WebKit Commit Bot

Comment 5 2009-11-11 12:00:48 PST

Comment on attachment 42985 [details] WebInspector: Adds another script tag test for WebInspector timeline records. Rejecting patch 42985 from commit-queue. Failed to run "['/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/svn-apply', '--reviewer', 'Pavel Feldman', '--force']" exit_code: 1 Last 500 characters of output: sts/inspector/timeline-paint.html patching file LayoutTests/inspector/timeline-parse-html-expected.txt patching file LayoutTests/inspector/timeline-parse-html.html patching file LayoutTests/inspector/timeline-recalculate-styles-expected.txt patching file LayoutTests/inspector/timeline-recalculate-styles.html patching file LayoutTests/inspector/timeline-test.js Hunk #1 FAILED at 39. Hunk #2 FAILED at 127. 2 out of 2 hunks FAILED -- saving rejects to file LayoutTests/inspector/timeline-test.js.rej

Eric Ayers

Comment 6 2009-11-11 12:16:50 PST

Created attachment 42988 [details] WebInspector: Adds Timeline record tests for Layout, Paint, Recalculate Style, Parse HTML and Mark Timeline fixed style problem and rebased patch.

WebKit Commit Bot

Comment 7 2009-11-11 13:35:51 PST

Comment on attachment 42988 [details] WebInspector: Adds Timeline record tests for Layout, Paint, Recalculate Style, Parse HTML and Mark Timeline Clearing flags on attachment: 42988 Committed r50839: <http://trac.webkit.org/changeset/50839>

WebKit Commit Bot

Comment 8 2009-11-11 13:35:55 PST

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.