Bug 31354

Summary: [Chromium] Remove WebViewImpl::dragSourceMovedTo()
Product: WebKit Reporter: Nate Chapin <japhet>
Component: WebKit Misc.Assignee: Nate Chapin <japhet>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
patch
none
patch2 eric: review+, commit-queue: commit-queue-

Description Nate Chapin 2009-11-11 08:45:40 PST 
http://trac.webkit.org/changeset/50786 removed EventHandler::dragSourceMovedTo(), which WebViewImpl in the Chormium API uses.  Should just be a straight delete.
Comment 1 Nate Chapin 2009-11-11 08:47:45 PST 
Created attachment 42964 [details]
patch
Comment 2 Dimitri Glazkov (Google) 2009-11-11 08:48:57 PST 
Comment on attachment 42964 [details]
patch

r=me, but you should really mention the changeset that removed it in the ChangeLog.
Comment 3 Nate Chapin 2009-11-11 09:07:05 PST 
http://trac.webkit.org/changeset/50808
Comment 4 Nate Chapin 2009-11-11 09:56:11 PST 
Created attachment 42973 [details]
patch2

Missed a couple of references...
Comment 5 Nate Chapin 2009-11-11 09:56:38 PST 
Missed some references, new patch attached.
Comment 6 Eric Seidel (no email) 2009-11-11 10:01:31 PST 
Comment on attachment 42973 [details]
patch2

LGTM.
Comment 7 Adam Barth 2009-11-12 18:50:07 PST 
Comment on attachment 42964 [details]
patch

This claims to have been landed.
Comment 8 WebKit Commit Bot 2009-11-12 19:07:07 PST 
Comment on attachment 42973 [details]
patch2

Rejecting patch 42973 from commit-queue.

Failed to run "['/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/svn-apply', '--reviewer', 'Eric Seidel', '--force']" exit_code: 1
patching file WebKit/chromium/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file WebKit/chromium/src/WebViewImpl.h
Hunk #1 FAILED at 127.
1 out of 1 hunk FAILED -- saving rejects to file WebKit/chromium/src/WebViewImpl.h.rej
patching file WebKit/chromium/public/WebView.h
Hunk #1 FAILED at 167.
1 out of 1 hunk FAILED -- saving rejects to file WebKit/chromium/public/WebView.h.rej
Comment 9 Nate Chapin 2009-11-13 09:16:22 PST 
Sorry about that.  I forgot that I hadn't closed this bug :-(