Bug 31341

Summary: Test unicode message sending over Web Socket
Product: WebKit Reporter: Yuzo Fujishima <yuzo>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, ukai, webkit.review.bot, yuzo
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Attachments:
Description Flags
Add web socket unicode message test
none
Add web socket unicode message test
none
Add web socket unicode message test none

Yuzo Fujishima
Reported 2009-11-11 02:33:10 PST
We should test if unicode messages can be sent over Web Socket.
Attachments
Add web socket unicode message test (5.61 KB, patch)
2009-11-11 02:36 PST, Yuzo Fujishima 		no flags
DetailsFormatted DiffDiff
Add web socket unicode message test (5.60 KB, patch)
2009-11-12 18:20 PST, Yuzo Fujishima 		no flags
DetailsFormatted DiffDiff
Add web socket unicode message test (5.61 KB, patch)
2009-12-03 20:49 PST, Yuzo Fujishima 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Yuzo Fujishima
Comment 1 2009-11-11 02:36:40 PST
Created attachment 42944 [details] Add web socket unicode message test
Yuzo Fujishima
Comment 2 2009-11-11 02:38:58 PST
Hi, reviewers, Can you review this patch and submit it, if it looks good? Yuzo
Yuzo Fujishima
Comment 3 2009-11-12 18:20:56 PST
Created attachment 43121 [details] Add web socket unicode message test
Yuzo Fujishima
Comment 4 2009-11-12 18:22:12 PST
Fixed such that the timeout timer is canceled on successful completion.
Eric Seidel (no email)
Comment 5 2009-11-26 21:24:47 PST
Comment on attachment 43121 [details] Add web socket unicode message test LGTM.
WebKit Commit Bot
Comment 6 2009-12-02 15:07:49 PST
Comment on attachment 43121 [details] Add web socket unicode message test Rejecting patch 43121 from commit-queue. Failed to run "['WebKitTools/Scripts/run-webkit-tests', '--no-launch-safari', '--quiet', '--exit-after-n-failures=1']" exit_code: 1 Running build-dumprendertree Running tests from /Users/eseidel/Projects/CommitQueue/LayoutTests Testing 11704 test cases. websocket/tests/unicode.html -> failed Exiting early after 1 failures. 11699 tests run. 356.03s total testing time 11698 test cases (99%) succeeded 1 test case (<1%) had incorrect layout 6 test cases (<1%) had stderr output
Yuzo Fujishima
Comment 7 2009-12-03 20:49:50 PST
Created attachment 44286 [details] Add web socket unicode message test
Yuzo Fujishima
Comment 8 2009-12-03 20:51:08 PST
Sorry for the test breakage. The symptom is the same as that of: https://bugs.webkit.org/show_bug.cgi?id=31337 I've tested the latest patch with HEAD. Can you try again? Yuzo
WebKit Review Bot
Comment 9 2009-12-03 20:52:26 PST
style-queue ran check-webkit-style on attachment 44286 [details] without any errors.
WebKit Commit Bot
Comment 10 2009-12-04 00:25:29 PST
Comment on attachment 44286 [details] Add web socket unicode message test Clearing flags on attachment: 44286 Committed r51686: <http://trac.webkit.org/changeset/51686>
WebKit Commit Bot
Comment 11 2009-12-04 00:25:34 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.