Summary: | Test unicode message sending over Web Socket | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Yuzo Fujishima <yuzo> | ||||||||
Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | commit-queue, ukai, webkit.review.bot, yuzo | ||||||||
Priority: | P2 | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | PC | ||||||||||
OS: | OS X 10.5 | ||||||||||
Attachments: |
|
Description
Yuzo Fujishima
2009-11-11 02:33:10 PST
Created attachment 42944 [details]
Add web socket unicode message test
Hi, reviewers, Can you review this patch and submit it, if it looks good? Yuzo Created attachment 43121 [details]
Add web socket unicode message test
Fixed such that the timeout timer is canceled on successful completion. Comment on attachment 43121 [details]
Add web socket unicode message test
LGTM.
Comment on attachment 43121 [details]
Add web socket unicode message test
Rejecting patch 43121 from commit-queue.
Failed to run "['WebKitTools/Scripts/run-webkit-tests', '--no-launch-safari', '--quiet', '--exit-after-n-failures=1']" exit_code: 1
Running build-dumprendertree
Running tests from /Users/eseidel/Projects/CommitQueue/LayoutTests
Testing 11704 test cases.
websocket/tests/unicode.html -> failed
Exiting early after 1 failures. 11699 tests run.
356.03s total testing time
11698 test cases (99%) succeeded
1 test case (<1%) had incorrect layout
6 test cases (<1%) had stderr output
Created attachment 44286 [details]
Add web socket unicode message test
Sorry for the test breakage. The symptom is the same as that of: https://bugs.webkit.org/show_bug.cgi?id=31337 I've tested the latest patch with HEAD. Can you try again? Yuzo style-queue ran check-webkit-style on attachment 44286 [details] without any errors.
Comment on attachment 44286 [details] Add web socket unicode message test Clearing flags on attachment: 44286 Committed r51686: <http://trac.webkit.org/changeset/51686> All reviewed patches have been landed. Closing bug. |