Summary: | Fix incorrect white-space in WebGLRenderingContext.idl | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Berend-Jan Wever <skylined> | ||||||
Component: | WebGL | Assignee: | Berend-Jan Wever <skylined> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | commit-queue, joepeck, oliver | ||||||
Priority: | P5 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | PC | ||||||||
OS: | Windows Vista | ||||||||
Attachments: |
|
Comment on attachment 42939 [details]
Patch that removes the offending white-space.
This needs a ChangeLog, but otherwise looks fine.
prepare-ChangeLog -b 31339
should generate what you want.
SkyLined, the space still exists. Did you want to redo this patch? Like Eric mentions, you just need a ChangeLog. Or, if you would rather I attach a patch for you, let me know. If you could create a patch for me, that would be great! I'm prioritizing a bunch of other things, so I won't get to do this myself anytime soon. But it would make my life easier later on, so I would really like to see the change. Thanks! Created attachment 52740 [details]
[PATCH] Remove Whitespace
(In reply to comment #3) > If you could create a patch for me, that would be great! I'm prioritizing a > bunch of other things, so I won't get to do this myself anytime soon. But it > would make my life easier later on, so I would really like to see the change. Let me know if there are any other issues that you find! Comment on attachment 52740 [details] [PATCH] Remove Whitespace Clearing flags on attachment: 52740 Committed r57214: <http://trac.webkit.org/changeset/57214> All reviewed patches have been landed. Closing bug. |
Created attachment 42939 [details] Patch that removes the offending white-space. WebGLRenderingContext.idl declares "drawElements" incorrectly: there is additional white-space after the method name. void drawElements (in unsigned long mode, in long count, in unsigned long type, in unsigned long offset); ^^^ This can cause an IDL parser to see it as an unnamed method that returns "void drawElements", which is incorrect. Oliver, can you apply this patch for me?