Bug 313373
| Summary: | [TestWebKitAPI] Use framework-style include for WebCoreTestSupport.h | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | David Kilzer (:ddkilzer) <ddkilzer> |
| Component: | Tools / Tests | Assignee: | David Kilzer (:ddkilzer) <ddkilzer> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
David Kilzer (:ddkilzer)
Ten TestWebKitAPI source files use `#import "WebCoreTestSupport.h"` (quoted include), which relies on `WebCoreTestSupport.h` being found via a `BUILT_PRODUCTS_DIR`-relative header search path. In Production builds where test support headers are installed to `$(SDK_DIR)/usr/local/include/WebCoreTestSupport/`, the quoted include fails because the header is not at the expected path.
Use `#import <WebCoreTestSupport/WebCoreTestSupport.h>` (framework-style include) instead, matching the installed directory layout. The system header search paths already include `$(SDK_DIR)/usr/local/include`, so the `WebCoreTestSupport/` prefix resolves correctly in both local engineering builds and Production builds.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/175638226>
David Kilzer (:ddkilzer)
Pull request: https://github.com/WebKit/WebKit/pull/63652
EWS
Committed 312094@main (3b8f24768a08): <https://commits.webkit.org/312094@main>
Reviewed commits have been landed. Closing PR #63652 and removing active labels.