Bug 313181
| Summary: | [Site Isolation] Replace parentFrameSecurityOrigin with precomputed bool in NavigationRequester | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Anthony Tarbinian <a.tarbinian> |
| Component: | New Bugs | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Anthony Tarbinian
Follows up on https://commits.webkit.org/311805@main by replacing the RefPtr<SecurityOrigin>
parentFrameSecurityOrigin field with a bool parentOriginIsSameAsTopOrigin.
The origin was only used in
isNavigationBlockedByThirdPartyIFrameRedirectBlocking to check
isSameOriginDomain against the top frame's origin. Since
NavigationRequester already carries topOrigin, precompute the
comparison at capture time in NavigationRequester::from() instead
of carrying a RefPtr<SecurityOrigin>.
Based on this review comment https://github.com/WebKit/WebKit/pull/61712#discussion_r3126415219
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/175463992>
Anthony Tarbinian
Pull request: https://github.com/WebKit/WebKit/pull/63479
EWS
Committed 312002@main (fac0cb3cde15): <https://commits.webkit.org/312002@main>
Reviewed commits have been landed. Closing PR #63479 and removing active labels.