Bug 31312

Summary: Decouple authentication panel callbacks from ResourceHandle
Product: WebKit Reporter: Alexey Proskuryakov <ap>
Component: PlatformAssignee: Alexey Proskuryakov <ap>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
proposed patch mitz: review+

Alexey Proskuryakov
Reported 2009-11-10 14:03:39 PST
SocketStream also wants to ask the user about credentials. For now, it's just proxy credentials. Patch forthcoming.
Attachments
proposed patch (28.41 KB, patch)
2009-11-10 14:11 PST, Alexey Proskuryakov 		mitz: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Alexey Proskuryakov
Comment 1 2009-11-10 14:11:57 PST
Created attachment 42893 [details] proposed patch
mitz
Comment 2 2009-11-10 14:25:20 PST
Comment on attachment 42893 [details] proposed patch > + * PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY > + * OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT > + * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE > + * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. > + */ > +#ifndef AuthenticationClient_h > +#define AuthenticationClient_h There should be an empty line before the #ifndef. Also, this is not the latest version of the license Apple uses (see <http://webkit.org/coding/bsd-license.html> and <http://trac.webkit.org/browser/trunk/WebKit/mac/WebView/WebVideoFullscreenHUDWindowController.h> for a comment-formatted version). r=me
Alexey Proskuryakov
Comment 3 2009-11-10 14:39:23 PST
Committed <http://trac.webkit.org/changeset/50772>.
Note You need to log in before you can comment on or make changes to this bug.