Bug 312811
| Summary: | [WPE][GTK] Enable assertions by default on DEVELOPER_MODE Release builds | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Carlos Alberto Lopez Perez <clopez> |
| Component: | WPE WebKit | Assignee: | Carlos Alberto Lopez Perez <clopez> |
| Status: | NEW | ||
| Severity: | Normal | CC: | bugs-noreply |
| Priority: | P2 | ||
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| See Also: |
https://bugs.webkit.org/show_bug.cgi?id=310315 https://bugs.webkit.org/show_bug.cgi?id=312922 |
||
Carlos Alberto Lopez Perez
Currently the EWS Release bots for GTK and WPE run with -DENABLE_ASSERTS=ON but the post-commit bots and the default builds for developers don't.
This causes issues because:
1) It is confusing for developers to see that their patch causes a assert on the EWS that they can't reproduce because the build config they have is not the same than the EWS
2) It makes our gardening efforts not aligned with the reality of the EWS. So that caused issues when we tried to use a less-forgiving algo for the EWS regarding flakies, see bug 310315 that had to be reverted because there were lot of flakies with asserts enabled that didn't accounted for.
So the solution to this problem is to enable asserts by default on DEVELOPER_MODE Release builds: for developers, for post-commit bots and for EWS bots.
Production builds (where DEVELOPER_MODE is off) remain without assertions enabled by default.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Carlos Alberto Lopez Perez
Pull request: https://github.com/WebKit/WebKit/pull/63155