Bug 31279 – Remove session storage setting

• Component: New Bugs
• Status: RESOLVED FIXED

[Jeremy Orlow]

Remove session storage from Settings.  It was added temporarily so we could disable it by default at runtime in Chromium.  We now disable these things in a different way, so it's time to remove it.  Qt also depended on this setting for a short period of time, but after talking to them we agreed that it should be removed.

This bug is the second half of https://bugs.webkit.org/show_bug.cgi?id=30602

[Jeremy Orlow]

Created attachment 42812 [details]
Patch

[Eric Seidel (no email)]

Comment on attachment 42812 [details]
Patch

How is it disabled now?  Are none of the WebKit ports affected by this change? (i.e. this call was only used within WebCore itself?)

[Jeremy Orlow]

QT and Chromium were the only ones that ever depended on it and they no longer do.  There's really no good reason why anyone would want to disable this feature when embedding WebKit and it's always been on by default anyway.

The flag was originally added because it was the best way to hide features from web pages while we were still getting them stable within Chromium and it mirrored how we LocalStorage is disabled (even though it's clear that setting is somewhat of an abuse since it can only half be disabled once a page uses LocalStorage and all pages in the page group need to share the same path and such).

It's also worth noting that we no longer use this method for adding features behind a runtime flag.

[Jeremy Orlow]

Committed r50754: <http://trac.webkit.org/changeset/50754>