Summary: | Prepended $$PWD to GENERATED_SOURCES_DIR | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Norbert Leser <norbert.leser> | ||||||
Component: | JavaScriptCore | Assignee: | Nobody <webkit-unassigned> | ||||||
Status: | RESOLVED WONTFIX | ||||||||
Severity: | Normal | CC: | commit-queue, eric, hausmann, laszlo.gombos, s.mathur, yongjun.zhang | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | PC | ||||||||
OS: | All | ||||||||
Bug Depends on: | |||||||||
Bug Blocks: | 27065 | ||||||||
Attachments: |
|
Created attachment 42793 [details]
Patch for prepending PWD to GENERATED_SOURCES_DIR
Corrected description of previous patch.
Comment on attachment 42793 [details] Patch for prepending PWD to GENERATED_SOURCES_DIR Clearing flags on attachment: 42793 Committed r50695: <http://trac.webkit.org/changeset/50695> All reviewed patches have been landed. Closing bug. Bug needs to be REOPENED as the landed fix had to be reverted because it broke clean build. Here is the error (breaks when it tries to compile standalone JSC). ../../../JavaScriptCore/pcre/pcre_tables.cpp:72:24: error: chartables.c: No such file or directory make[1]: *** [obj/debug/pcre_tables.o] Error 1 make: *** [sub-JavaScriptCore-jsc-pro-make_default-ordered] Error 2 For some reason I can not change the status to REOPEN. You look to have 3 separate bugzilla accounts. :( I've added edit bugs permissions to a second one. Starting a rollout per laszlo's request. Nevermind. Laszlo already rolled it out in r50701. Please make sure you update the bug with the revision number if you do a rollout. Sorry, to hear that it broke another build. Laszlo, can you specify what your build target was so I can try to reproduce it and work on a potential fix. (In reply to comment #8) > Sorry, to hear that it broke another build. Laszlo, can you specify what your > build target was so I can try to reproduce it and work on a potential fix. I saw the build break first on Mac (build-webkit --qt --no-svg --debug) and reproduced on Linux as well (build-webkit --qt --no--svg --release). QtWebKit library builds Ok, but standalone jsc failed. Does not seems to be an issue any more (especially after pre-generation step). |
Created attachment 42791 [details] Patch for USERINCLUDE paths for symbian Prepended $$PWD to GENERATED_SOURCES_DIR to avoid potential ambiguities when included from WebCore.pro. Some preprocessors consider this GENERATED_SOURCES_DIR relative to current invoking dir (e.g., ./WebCore), and not the working dir of JavaCriptCore.pri (i.e., ../JavaScriptCore/).