Bug 31261

Summary: [Gtk] Build from tarball fails with --enable-introspection
Product: WebKit Reporter: Priit Laes (IRC: plaes) <plaes>
Component: WebKitGTKAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Linux   
Attachments:
Description Flags
distcheck-enable-gobject-introspection.patch none

Priit Laes (IRC: plaes)
Reported 2009-11-09 09:45:17 PST
We need to pass --enable-introspection (and possibly something else) to DISTCHECK_FLAGS so all the support files are included in the tarball...
Attachments
distcheck-enable-gobject-introspection.patch (1.56 KB, patch)
2009-11-09 09:52 PST, Priit Laes (IRC: plaes) 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Priit Laes (IRC: plaes)
Comment 1 2009-11-09 09:52:00 PST
Created attachment 42761 [details] distcheck-enable-gobject-introspection.patch This is speculative fix, but untested (as `make distcheck` is broken on my current dev-machine) :S
Oliver Hunt
Comment 2 2009-11-09 14:22:24 PST
Comment on attachment 42761 [details] distcheck-enable-gobject-introspection.patch I'm not a gtk person, but this patch seems sufficiently simple for me to feel comfortable r+-ing it. If anyone with more familiarity with gtk deems otherwise they're perfectly welcome to r- or scold me, or whatever :D
WebKit Commit Bot
Comment 3 2009-11-09 17:12:09 PST
Comment on attachment 42761 [details] distcheck-enable-gobject-introspection.patch Clearing flags on attachment: 42761 Committed r50699: <http://trac.webkit.org/changeset/50699>
WebKit Commit Bot
Comment 4 2009-11-09 17:12:14 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.