Bug 31261 - [Gtk] Build from tarball fails with --enable-introspection
Summary: [Gtk] Build from tarball fails with --enable-introspection
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Linux
: P2 Normal
Assignee: Nobody
Depends on:
Reported: 2009-11-09 09:45 PST by Priit Laes (IRC: plaes)
Modified: 2009-11-09 17:12 PST (History)
1 user (show)

See Also:

distcheck-enable-gobject-introspection.patch (1.56 KB, patch)
2009-11-09 09:52 PST, Priit Laes (IRC: plaes)
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Priit Laes (IRC: plaes) 2009-11-09 09:45:17 PST
We need to pass --enable-introspection (and possibly something else) to DISTCHECK_FLAGS so all the support files are included in the tarball...
Comment 1 Priit Laes (IRC: plaes) 2009-11-09 09:52:00 PST
Created attachment 42761 [details]

This is speculative fix, but untested (as `make distcheck` is broken on my current dev-machine) :S
Comment 2 Oliver Hunt 2009-11-09 14:22:24 PST
Comment on attachment 42761 [details]

I'm not a gtk person, but this patch seems sufficiently simple for me to feel comfortable r+-ing it.

If anyone with more familiarity with gtk deems otherwise they're perfectly welcome to r- or scold me, or whatever :D
Comment 3 WebKit Commit Bot 2009-11-09 17:12:09 PST
Comment on attachment 42761 [details]

Clearing flags on attachment: 42761

Committed r50699: <http://trac.webkit.org/changeset/50699>
Comment 4 WebKit Commit Bot 2009-11-09 17:12:14 PST
All reviewed patches have been landed.  Closing bug.