[Qt] Remove the sessionStorage setting (per Page)

• Component: WebKit Qt
• Status: RESOLVED FIXED

[Laszlo Gombos]

This setting does not quite work as a per Page setting (can not turn it off once it has been turned on). The setting does not control persistent data - I do not believe QtWebKit had a strong use-case for this.

Note that this setting API is now in QtWebKit 4.6 production branch - so this patch can only be landed on the trunk if there is a commitment to cherry-pick this change to Qt 4.6 final - I think there is still time.

This is a response to some discussion with Jeremy Orlow on #qtwebkit. Jeremy had a patch related to sessionStorage setting - if the setting will be removed from the Qt API Jeremy's patch should be re-landed as well - see http://trac.webkit.org/changeset/50569.

[Laszlo Gombos]

Created attachment 42728 [details]
remove sessionStorage setting API

[Kenneth Rohde Christiansen]

If it is not right, we should remove it for now. But one other thing. Session storage is per page group, and according to the spec, if you create a tab or new window from a page group (like open a "next" link in a wizard in another tab) it should clone the session storage.

I wonder if we need a class for dealing with these issues.

Does local storage suffer from any of these issues?

[Kenneth Rohde Christiansen]

One question. Is it turned on by default? I at least think we should do that.

[Laszlo Gombos]

Comment on attachment 42728 [details]
remove sessionStorage setting API

missing change in qwebsettings.h.

[Laszlo Gombos]

Landed as r50659 -  http://trac.webkit.org/changeset/50659.