|Summary:||DateMath.cpp needs to be split into JSC and WTF portions.|
|Product:||WebKit||Reporter:||David Levin <levin>|
|Severity:||Normal||CC:||ggaren, laszlo.gombos, levin|
|Version:||528+ (Nightly build)|
Description David Levin 2009-11-08 18:24:39 PST
Comment 1 David Levin 2009-11-08 18:26:26 PST
Comment 2 David Levin 2009-11-08 18:34:33 PST
I divided up the functionality in http://trac.webkit.org/changeset/50633 but left in one file for the moment so that I could get in the chromium build fix more quickly.
Comment 3 Geoffrey Garen 2009-11-09 11:59:18 PST
Comment 4 David Levin 2009-11-09 13:39:22 PST
Well, this totally broke the chromium port. I figured this must have been an oversight because I know that folks in WK take great care not to break any of the ports as evidenced by subsequent fixes for qt, etc. So I was trying to fix one of the ports as quickly as possible which is why I did this quickly without discussing it, *but* I created this bug and cc'ed you so I wasn't trying to hide this at all. In general as I read your patch it was about using exec to have a perf increase, and I kept that part of it. Anyway, I don't know how well we can discuss this in a bug but I'm happy to work with you to figure something out. I'm in irc as I usually am (dave_levin).
Comment 5 Geoffrey Garen 2009-11-11 13:09:16 PST
Comment 6 David Levin 2009-11-11 15:56:27 PST
(In reply to comment #5) I don't think that going back and forth in this bug is the best way to resolve this. I tried to ping you in irc yesterday but we missed each other. > It also hasn't been a priority for me because Chromium developers have told me > not to make it a priority -- the implication being that we shouldn't have to > slow down mainline development of WebKit to support v8. Please let me know if > your position on this has changed. Well, if you can keep it building, then great. If not, then a chromium person needs to go around and clean up as best as possible after these changes to keep chromium building in some way. Just like any other port we make it a priority to keep building all the time.