Bug 31244

Summary: [GTK] Remove WebSocket configuration from WebKitWebSettings
Product: WebKit Reporter: Martin Robinson <mrobinson>
Component: WebKitGTKAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, eric, gustavo, pnormand
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: All   
Attachments:
Description Flags
Patch for this issue
jmalonzo: review+, commit-queue: commit-queue-
Patch for this issue (against ToT)
none
Follow-up patch for DRT none

Martin Robinson
Reported 2009-11-08 18:01:21 PST
Bug 29896 disabled runtime configuration of WebSockets for all non-Chromium/V8 ports. We need to remove the now non-functional enable-web-sockets property from WebKitWebSettings.
Attachments
Patch for this issue (4.46 KB, patch)
2009-11-08 18:03 PST, Martin Robinson 		jmalonzo: review+
commit-queue: commit-queue-
DetailsFormatted DiffDiff
Patch for this issue (against ToT) (4.61 KB, patch)
2009-11-09 19:16 PST, Martin Robinson 		no flags
DetailsFormatted DiffDiff
Follow-up patch for DRT (1.73 KB, patch)
2009-11-10 03:09 PST, Philippe Normand 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Martin Robinson
Comment 1 2009-11-08 18:03:03 PST
Created attachment 42724 [details] Patch for this issue I've attached a patch removing this property.
Jan Alonzo
Comment 2 2009-11-09 01:13:35 PST
Comment on attachment 42724 [details] Patch for this issue r=me. Thanks for the cleanup.
WebKit Commit Bot
Comment 3 2009-11-09 01:17:11 PST
Comment on attachment 42724 [details] Patch for this issue Rejecting patch 42724 from commit-queue. Failed to run "['/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/svn-apply', '--reviewer', 'Jan Alonzo', '--force']" exit_code: 1 Last 500 characters of output: --------------------------------------------- patching file WebKit/gtk/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file WebKit/gtk/webkit/webkitwebsettings.cpp Hunk #1 succeeded at 96 with fuzz 2. Hunk #2 FAILED at 137. Hunk #3 succeeded at 652 (offset 2 lines). Hunk #4 succeeded at 879 (offset 21 lines). Hunk #5 succeeded at 996 (offset 24 lines). Hunk #6 succeeded at 1066 (offset 27 lines). 1 out of 6 hunks FAILED -- saving rejects to file WebKit/gtk/webkit/webkitwebsettings.cpp.rej
Eric Seidel (no email)
Comment 4 2009-11-09 16:59:43 PST
Looks like the patch just rotted a little. It will need to be updated by the author or someone can attempt to manually apply it.
Martin Robinson
Comment 5 2009-11-09 19:16:50 PST
Created attachment 42841 [details] Patch for this issue (against ToT) I've attached an updated patch against ToT.
WebKit Commit Bot
Comment 6 2009-11-10 01:15:38 PST
Comment on attachment 42841 [details] Patch for this issue (against ToT) Clearing flags on attachment: 42841 Committed r50724: <http://trac.webkit.org/changeset/50724>
WebKit Commit Bot
Comment 7 2009-11-10 01:15:42 PST
All reviewed patches have been landed. Closing bug.
Philippe Normand
Comment 8 2009-11-10 03:03:39 PST
DRT still sets that non-existing property and issues a warning
Gustavo Noronha (kov)
Comment 9 2009-11-10 03:06:05 PST
One more place needs to be cleaned up, it seems.
Philippe Normand
Comment 10 2009-11-10 03:09:53 PST
Created attachment 42856 [details] Follow-up patch for DRT
Jan Alonzo
Comment 11 2009-11-10 03:15:11 PST
Comment on attachment 42856 [details] Follow-up patch for DRT r=me.
WebKit Commit Bot
Comment 12 2009-11-10 03:42:42 PST
Comment on attachment 42856 [details] Follow-up patch for DRT Clearing flags on attachment: 42856 Committed r50737: <http://trac.webkit.org/changeset/50737>
WebKit Commit Bot
Comment 13 2009-11-10 03:42:47 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.