Summary: | [GTK] Remove WebSocket configuration from WebKitWebSettings | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Martin Robinson <mrobinson> | ||||||||
Component: | WebKitGTK | Assignee: | Nobody <webkit-unassigned> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | commit-queue, eric, gustavo, pnormand | ||||||||
Priority: | P2 | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | PC | ||||||||||
OS: | All | ||||||||||
Attachments: |
|
Description
Martin Robinson
2009-11-08 18:01:21 PST
Created attachment 42724 [details]
Patch for this issue
I've attached a patch removing this property.
Comment on attachment 42724 [details]
Patch for this issue
r=me. Thanks for the cleanup.
Comment on attachment 42724 [details]
Patch for this issue
Rejecting patch 42724 from commit-queue.
Failed to run "['/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/svn-apply', '--reviewer', 'Jan Alonzo', '--force']" exit_code: 1
Last 500 characters of output:
---------------------------------------------
patching file WebKit/gtk/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file WebKit/gtk/webkit/webkitwebsettings.cpp
Hunk #1 succeeded at 96 with fuzz 2.
Hunk #2 FAILED at 137.
Hunk #3 succeeded at 652 (offset 2 lines).
Hunk #4 succeeded at 879 (offset 21 lines).
Hunk #5 succeeded at 996 (offset 24 lines).
Hunk #6 succeeded at 1066 (offset 27 lines).
1 out of 6 hunks FAILED -- saving rejects to file WebKit/gtk/webkit/webkitwebsettings.cpp.rej
Looks like the patch just rotted a little. It will need to be updated by the author or someone can attempt to manually apply it. Created attachment 42841 [details]
Patch for this issue (against ToT)
I've attached an updated patch against ToT.
Comment on attachment 42841 [details] Patch for this issue (against ToT) Clearing flags on attachment: 42841 Committed r50724: <http://trac.webkit.org/changeset/50724> All reviewed patches have been landed. Closing bug. DRT still sets that non-existing property and issues a warning One more place needs to be cleaned up, it seems. Created attachment 42856 [details]
Follow-up patch for DRT
Comment on attachment 42856 [details]
Follow-up patch for DRT
r=me.
Comment on attachment 42856 [details] Follow-up patch for DRT Clearing flags on attachment: 42856 Committed r50737: <http://trac.webkit.org/changeset/50737> All reviewed patches have been landed. Closing bug. |