Bug 31214
| Summary: | check-webkit-style needs to be taught about "WebCommon.h" | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Eric Seidel (no email) <eric> |
| Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED INVALID | ||
| Severity: | Normal | CC: | dglazkov, fishd, hamaji, levin, mrobinson, yaar |
| Priority: | P2 | ||
| Version: | 528+ (Nightly build) | ||
| Hardware: | PC | ||
| OS: | OS X 10.5 | ||
Eric Seidel (no email)
check-webkit-style needs to be taught about "WebCommon.h"
The Chromium WebKit API layer uses a "WebCommon.h" instead of a config.h. check-webkit-style doesn't know about this special header and flags it as unsorted.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
David Levin
I did a quick look at a few files. It doesn't take the place of config.h which is for cpp files.
It seems only to be used in a few .h files and there doesn't seem to be a down side to sorting it like any other file.
Eric Seidel (no email)
OK, then I'll fix the sorting in the few files and we can close this.
Dimitri Glazkov (Google)
I disagree. I would like to keep WebCommon.h at the top.
Martin Robinson
Chromium is no longer part of the tree and there are no remaining references to WebCommon.h.