| Summary: | V8DOMWindowCustom.cpp is missing WEB_SOCKETS guard on include | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Steve Block <steveblock> | ||||
| Component: | WebCore Misc. | Assignee: | Steve Block <steveblock> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | benm, commit-queue, eric, steveblock | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | All | ||||||
| OS: | All | ||||||
| Attachments: |
|
||||||
|
Description
Steve Block
2009-11-06 10:58:43 PST
Created attachment 42660 [details] Patch 1 for Bug 31209 Comment on attachment 42660 [details] Patch 1 for Bug 31209 LGTM. Comment on attachment 42660 [details] Patch 1 for Bug 31209 Build fixes don't require review, but review is always nice for any patch. :) Comment on attachment 42660 [details] Patch 1 for Bug 31209 Rejecting patch 42660 from commit-queue. Failed to run "['WebKitTools/Scripts/run-webkit-tests', '--no-launch-safari', '--quiet', '--exit-after-n-failures=1']" exit_code: 1 Running build-dumprendertree Running tests from /Users/eseidel/Projects/CommitQueue/LayoutTests Testing 11573 test cases. transitions/transition-end-event-transform.html -> failed Exiting early after 1 failures. 11507 tests run. 484.99s total testing time 11506 test cases (99%) succeeded 1 test case (<1%) had incorrect layout 6 test cases (<1%) had stderr output Comment on attachment 42660 [details] Patch 1 for Bug 31209 Must be a flakey test. I'll file a bug. Turns out this was a known issue. Updated bug 30029. Comment on attachment 42660 [details] Patch 1 for Bug 31209 Clearing flags on attachment: 42660 Committed r50603: <http://trac.webkit.org/changeset/50603> All reviewed patches have been landed. Closing bug. |