Bug 31197

Summary:

Implemented a timezone cache not based on Mac OS X's notify_check API

Product:

WebKit

Reporter:

Geoffrey Garen <ggaren>

Component:

JavaScriptCore

Assignee:

Geoffrey Garen <ggaren>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

darin, eric

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

OS X 10.5

Attachments:

Description	Flags
patch	oliver: review+

Geoffrey Garen

Reported 2009-11-05 22:17:05 PST

Created attachment 42629 [details] patch Patch coming.

Attachments
patch (26.19 KB, patch) 2009-11-05 22:17 PST, Geoffrey Garen	oliver: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Geoffrey Garen

Comment 1 2009-11-05 22:27:50 PST

*** Bug 15853 has been marked as a duplicate of this bug. ***

Geoffrey Garen

Comment 2 2009-11-05 22:54:14 PST

Still working out some Windows build issues...

Eric Seidel (no email)

Comment 3 2009-11-05 23:04:00 PST

So in a long-running gmail instance we no longer would notice daylight savings time changes, correct?

Darin Adler

Comment 4 2009-11-06 08:22:32 PST

(In reply to comment #3) > So in a long-running gmail instance we no longer would notice daylight savings > time changes, correct? If the entire long-running gmail "instance" is a single JavaScript function that never returns, then you're correct. But I don't know of anything like that.

Eric Seidel (no email)

Comment 5 2009-11-06 09:00:46 PST

Ah. I incorrectly read "VM invocation" as "VM instance" and assumed there was one per page. Thank you for the clarification.

Geoffrey Garen

Comment 6 2009-11-06 11:53:15 PST

(In reply to comment #3) > So in a long-running gmail instance we no longer would notice daylight savings > time changes, correct? (Minor correction: this patch is about timezone, not daylight savings time.) Note that, in v8, in a long-runing gmail instance you will indeed not notice timezone changes. Part of the design of this patch is to enable the VM to notice timezone changes in a not-too-surprising way, given that other VMs don't notice them at all.

Eric Seidel (no email)

Comment 7 2009-11-06 12:19:45 PST

(In reply to comment #6) > (In reply to comment #3) > > So in a long-running gmail instance we no longer would notice daylight savings > > time changes, correct? > > (Minor correction: this patch is about timezone, not daylight savings time.) > > Note that, in v8, in a long-runing gmail instance you will indeed not notice > timezone changes. Part of the design of this patch is to enable the VM to > notice timezone changes in a not-too-surprising way, given that other VMs don't > notice them at all. Thank you for the clarifications.

Eric Seidel (no email)

Comment 8 2009-11-09 17:27:57 PST

Was landed as r50590.

Note You need to log in before you can comment on or make changes to this bug.