| Summary: | Implemented a timezone cache not based on Mac OS X's notify_check API | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Geoffrey Garen <ggaren> | ||||
| Component: | JavaScriptCore | Assignee: | Geoffrey Garen <ggaren> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | darin, eric | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | PC | ||||||
| OS: | OS X 10.5 | ||||||
| Attachments: |
|
||||||
*** Bug 15853 has been marked as a duplicate of this bug. *** Still working out some Windows build issues... So in a long-running gmail instance we no longer would notice daylight savings time changes, correct? (In reply to comment #3) > So in a long-running gmail instance we no longer would notice daylight savings > time changes, correct? If the entire long-running gmail "instance" is a single JavaScript function that never returns, then you're correct. But I don't know of anything like that. Ah. I incorrectly read "VM invocation" as "VM instance" and assumed there was one per page. Thank you for the clarification. (In reply to comment #3) > So in a long-running gmail instance we no longer would notice daylight savings > time changes, correct? (Minor correction: this patch is about timezone, not daylight savings time.) Note that, in v8, in a long-runing gmail instance you will indeed not notice timezone changes. Part of the design of this patch is to enable the VM to notice timezone changes in a not-too-surprising way, given that other VMs don't notice them at all. (In reply to comment #6) > (In reply to comment #3) > > So in a long-running gmail instance we no longer would notice daylight savings > > time changes, correct? > > (Minor correction: this patch is about timezone, not daylight savings time.) > > Note that, in v8, in a long-runing gmail instance you will indeed not notice > timezone changes. Part of the design of this patch is to enable the VM to > notice timezone changes in a not-too-surprising way, given that other VMs don't > notice them at all. Thank you for the clarifications. |
Created attachment 42629 [details] patch Patch coming.