Bug 311960
| Summary: | [libpas] De-singletonize pas_large_map to allow for multiple instances | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Marcus Plutowski <marcus_plutowski> |
| Component: | bmalloc | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | ggaren, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Marcus Plutowski
rdar://174512866
Currently, libpas uses singletons for the various large-map hashtables (and associated metadata):
```
PAS_API extern pas_large_map_hashtable pas_large_map_hashtable_instance;
PAS_API extern pas_large_map_hashtable_in_flux_stash pas_large_map_hashtable_instance_in_flux_stash;
PAS_API extern pas_small_large_map_hashtable pas_small_large_map_hashtable_instance;
PAS_API extern pas_small_large_map_hashtable_in_flux_stash pas_small_large_map_hashtable_instance_in_flux_stash;
PAS_API extern pas_tiny_large_map_hashtable pas_tiny_large_map_hashtable_instance;
PAS_API extern pas_tiny_large_map_hashtable_in_flux_stash pas_tiny_large_map_hashtable_instance_in_flux_stash;
PAS_API extern pas_tiny_large_map_second_level_hashtable_in_flux_stash pas_tiny_large_map_second_level_hashtable_in_flux_stash_instance;
```
This is unnecessary, and should be changed to help clear the way for future projects. In particular, we should be able to instantiate an arbitrary number of large-map instances (for each of the above types), and associate each large-heap with an arbitrary large map.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Marcus Plutowski
Pull request: https://github.com/WebKit/WebKit/pull/62476
EWS
Committed 311318@main (2c7b7e22dca5): <https://commits.webkit.org/311318@main>
Reviewed commits have been landed. Closing PR #62476 and removing active labels.