Bug 311853

Summary:	[GFC][Cleanup] Change ADD_REASON_AND_RETURN_IF_NEEDED to accept GridAvoidanceReason values directly
Product:	WebKit	Reporter:	Sammy Gill <sgill26>
Component:	Layout and Rendering	Assignee:	Sammy Gill <sgill26>
Status:	RESOLVED FIXED
Severity:	Normal	CC:	bfulgham, simon.fraser, webkit-bug-importer, zalan
Priority:	P2	Keywords:	InRadar
Version:	WebKit Nightly Build
Hardware:	Unspecified
OS:	Unspecified

Sammy Gill

Reported 2026-04-09 14:15:17 PDT

Right now the macro accepts and uses the values of the enum in the definition (i.e. it prepends GridAvoidanceReason to the token when using it). This prevents us from passing in and using an lvalue that we have.

Attachments
Add attachment proposed patch, testcase, etc.

Radar WebKit Bug Importer

Comment 1 2026-04-09 14:15:26 PDT

<rdar://problem/174438472>

Sammy Gill

Comment 2 2026-04-09 14:30:52 PDT

Pull request: https://github.com/WebKit/WebKit/pull/62386

EWS

Comment 3 2026-04-09 20:44:10 PDT

Committed 310896@main (3b5e0fe59a00): <https://commits.webkit.org/310896@main> Reviewed commits have been landed. Closing PR #62386 and removing active labels.

Note You need to log in before you can comment on or make changes to this bug.