Bug 31185

Summary: [Qt] Layout Test editing/undo/undo-deleteWord.html fails
Product: WebKit Reporter: Chang Shu <cshu>
Component: WebKit QtAssignee: Chang Shu <cshu>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, laszlo.gombos
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Linux   
Attachments:
Description Flags
fix patch
none
update after Eric's comment none

Description Chang Shu 2009-11-05 13:36:51 PST 
Build bot reports failure on the above test case:
http://build.webkit.org/results/Qt%20Linux%20Release/r50408%20%283364%29/results.html
Comment 1 Chang Shu 2009-11-05 13:44:12 PST 
Created attachment 42592 [details]
fix patch
Comment 2 Eric Seidel (no email) 2009-11-05 15:21:10 PST 
Comment on attachment 42592 [details]
fix patch

This change should really have a code comment to explain what 8 and 127 are.  Using nicely named constants would be even better.
Comment 3 Chang Shu 2009-11-06 06:32:00 PST 
Created attachment 42649 [details]
update after Eric's comment
Comment 4 Eric Seidel (no email) 2009-11-08 10:36:09 PST 
Comment on attachment 42649 [details]
update after Eric's comment

We generally use static variables instead of #defines, but we can always change that later.  cq+
Comment 5 WebKit Commit Bot 2009-11-08 10:51:33 PST 
Comment on attachment 42649 [details]
update after Eric's comment

Clearing flags on attachment: 42649

Committed r50624: <http://trac.webkit.org/changeset/50624>
Comment 6 WebKit Commit Bot 2009-11-08 10:51:37 PST 
All reviewed patches have been landed.  Closing bug.
Comment 7 Chang Shu 2009-11-09 06:21:30 PST 
(In reply to comment #4)
> (From update of attachment 42649 [details])
> We generally use static variables instead of #defines, but we can always change
> that later.  cq+

Will keep that in mind.