|Summary:||[Qt] Layout Test editing/undo/undo-deleteWord.html fails|
|Product:||WebKit||Reporter:||Chang Shu <cshu>|
|Component:||WebKit Qt||Assignee:||Chang Shu <cshu>|
|Version:||528+ (Nightly build)|
Description Chang Shu 2009-11-05 13:36:51 PST
Build bot reports failure on the above test case: http://build.webkit.org/results/Qt%20Linux%20Release/r50408%20%283364%29/results.html
Comment 2 Eric Seidel (no email) 2009-11-05 15:21:10 PST
Comment on attachment 42592 [details] fix patch This change should really have a code comment to explain what 8 and 127 are. Using nicely named constants would be even better.
Comment 3 Chang Shu 2009-11-06 06:32:00 PST
Created attachment 42649 [details] update after Eric's comment
Comment 4 Eric Seidel (no email) 2009-11-08 10:36:09 PST
Comment on attachment 42649 [details] update after Eric's comment We generally use static variables instead of #defines, but we can always change that later. cq+
Comment 5 WebKit Commit Bot 2009-11-08 10:51:33 PST
Comment on attachment 42649 [details] update after Eric's comment Clearing flags on attachment: 42649 Committed r50624: <http://trac.webkit.org/changeset/50624>
Comment 6 WebKit Commit Bot 2009-11-08 10:51:37 PST
All reviewed patches have been landed. Closing bug.