Bug 31152

Summary:

Fix ASSERT(currentStyle = renderStyle())

Product:

WebKit

Reporter:

Yuta Kitamura <yutak>

Component:

DOM

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, eric

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

OS X 10.5

Attachments:

Description	Flags
Fix ASSERT(currentStyle = renderStyle()).	none
Fix ASSERT(currentStyle = renderStyle()). (v2: Fixed Changelog)	none

Yuta Kitamura

Reported 2009-11-04 21:25:16 PST

In WebCore/dom/Element.cpp, line 762: ASSERT(currentStyle = renderStyle()); Clearly this doesn't do what we expected it to do...

Attachments
Fix ASSERT(currentStyle = renderStyle()). (1.05 KB, patch) 2009-11-04 21:32 PST, Yuta Kitamura	no flags	Details Formatted Diff Diff
Fix ASSERT(currentStyle = renderStyle()). (v2: Fixed Changelog) (1005 bytes, patch) 2009-11-05 21:34 PST, Yuta Kitamura	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Yuta Kitamura

Comment 1 2009-11-04 21:32:20 PST

Created attachment 42545 [details] Fix ASSERT(currentStyle = renderStyle()).

Alexey Proskuryakov

Comment 2 2009-11-05 10:20:27 PST

Comment on attachment 42545 [details] Fix ASSERT(currentStyle = renderStyle()). Wow. r=me The ChangeLog is not in great shape - why repeat the same line twice, for example? Also, the line saying 'We should have used "==" instead of "=". should go after the automatically inserted function name (pseudoStyleCacheIsInvalid), because it describes what was changed in that particular function.

Yuta Kitamura

Comment 3 2009-11-05 16:40:38 PST

Thanks for your comment! I'll be more careful in writing Changelog.

Eric Seidel (no email)

Comment 4 2009-11-05 16:45:17 PST

Comment on attachment 42545 [details] Fix ASSERT(currentStyle = renderStyle()). Actually, cq-. I really think we should fix the ChangeLog before landing this.

Yuta Kitamura

Comment 5 2009-11-05 16:48:24 PST

(In reply to comment #4) > (From update of attachment 42545 [details]) > Actually, cq-. I really think we should fix the ChangeLog before landing this. Thanks. I'll do it.

Yuta Kitamura

Comment 6 2009-11-05 21:34:34 PST

Created attachment 42628 [details] Fix ASSERT(currentStyle = renderStyle()). (v2: Fixed Changelog)

Eric Seidel (no email)

Comment 7 2009-11-05 23:04:45 PST

Comment on attachment 42628 [details] Fix ASSERT(currentStyle = renderStyle()). (v2: Fixed Changelog) Looks great! Thanks for fixing the ChangeLog nit.

WebKit Commit Bot

Comment 8 2009-11-05 23:26:23 PST

Comment on attachment 42628 [details] Fix ASSERT(currentStyle = renderStyle()). (v2: Fixed Changelog) Clearing flags on attachment: 42628 Committed r50592: <http://trac.webkit.org/changeset/50592>

WebKit Commit Bot

Comment 9 2009-11-05 23:26:27 PST

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.