Bug 31139

Summary:

Web Inspector: Make resource-related records in timeline actually take some time.

Product:

WebKit

Reporter:

Pavel Feldman <pfeldman>

Component:

Web Inspector (Deprecated)

Assignee:

Pavel Feldman <pfeldman>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bweinstein, joepeck, rik, timothy

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
[PATCH]	timothy: review+
[IMAGE]	none
[IMAGE] Minimum length causes overlapping. 'send request' is supposed to be 0 length...	none
[IMAGE] Proper min-width and negative margin.	none

Pavel Feldman

Reported 2009-11-04 12:31:53 PST

Currently resource loading is captured as three dots: - send request, - receive response, - finish load Not too useful. I'd like to show that it too XX many seconds to receive response, X many seconds to finish loading once response is there.

Attachments
[PATCH] (4.02 KB, patch) 2009-11-04 12:34 PST, Pavel Feldman	timothy: review+	Details Formatted Diff Diff
[IMAGE] (198.61 KB, image/png) 2009-11-04 12:36 PST, Pavel Feldman	no flags	Details
[IMAGE] Minimum length causes overlapping. 'send request' is supposed to be 0 length... (128.24 KB, image/png) 2009-11-04 22:14 PST, Pavel Feldman	no flags	Details
[IMAGE] Proper min-width and negative margin. (120.25 KB, image/png) 2009-11-04 22:22 PST, Pavel Feldman	no flags	Details
View All Add attachment proposed patch, testcase, etc.

Pavel Feldman

Comment 1 2009-11-04 12:34:18 PST

Created attachment 42512 [details] [PATCH]

Pavel Feldman

Comment 2 2009-11-04 12:36:01 PST

Created attachment 42513 [details] [IMAGE]

Timothy Hatcher

Comment 3 2009-11-04 12:49:49 PST

Comment on attachment 42512 [details] [PATCH] I don't think this is right. In principle the change sounds good, but the screenshot does not have the 3 bars lining up like I would expect. I don't expect overlap, but I see significant overlapping. Also the "Send Request" row are not using showing the WebInspector.displayNameForURL for some reason, it is the full URL.

Pavel Feldman

Comment 4 2009-11-04 22:03:05 PST

(In reply to comment #3) > (From update of attachment 42512 [details]) > I don't think this is right. In principle the change sounds good, but the > screenshot does not have the 3 bars lining up like I would expect. I don't > expect overlap, but I see significant overlapping. > I think the overlap is there due to rendering (borders, margins, etc.). Absolute timing for those does not overlap. > Also the "Send Request" row are not using showing the > WebInspector.displayNameForURL for some reason, it is the full URL. Will Fix.

Pavel Feldman

Comment 5 2009-11-04 22:14:04 PST

Created attachment 42548 [details] [IMAGE] Minimum length causes overlapping. 'send request' is supposed to be 0 length... Also the all use displayNameForURL. It is just that the timeline entry is there before the resource for 'Send Request', so it only gets domain trimmed. We should update it upon receive response or something.

Pavel Feldman

Comment 6 2009-11-04 22:22:36 PST

Created attachment 42549 [details] [IMAGE] Proper min-width and negative margin.

Timothy Hatcher

Comment 7 2009-11-04 23:02:57 PST

Comment on attachment 42512 [details] [PATCH] r+ with the min-width fix.

Pavel Feldman

Comment 8 2009-11-05 02:08:23 PST

Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebCore/ChangeLog M WebCore/English.lproj/localizedStrings.js M WebCore/inspector/front-end/TimelinePanel.js M WebCore/inspector/front-end/inspector.css Committed r50560 (landed with margin fix and start loading url fix)

Note You need to log in before you can comment on or make changes to this bug.