Bug 31124

Summary: Tell the WebFrameLoadDelegate when window objects in isolated worlds are cleared
Product: WebKit Reporter: Adam Roben (:aroben) <aroben>
Component: WebKit APIAssignee: Adam Roben (:aroben) <aroben>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, dglazkov, eric, hyatt, sam
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Other   
OS: All   
Bug Depends on: 31414    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Tell the WebFrameLoadDelegate when window objects in isolated worlds are cleared
none
Tell the WebFrameLoadDelegate when window objects in isolated worlds are cleared hyatt: review+

Adam Roben (:aroben)
Reported 2009-11-04 09:40:13 PST
Created attachment 42489 [details] Patch We should tell the WebFrameLoadDelegate when window objects in isolated worlds are cleared so that they can modify the objects as needed.
Attachments
Patch (47.28 KB, patch)
2009-11-04 09:40 PST, Adam Roben (:aroben) 		no flags
DetailsFormatted DiffDiff
Tell the WebFrameLoadDelegate when window objects in isolated worlds are cleared (57.37 KB, patch)
2009-11-13 12:29 PST, Adam Roben (:aroben) 		no flags
DetailsFormatted DiffDiff
Tell the WebFrameLoadDelegate when window objects in isolated worlds are cleared (56.70 KB, patch)
2009-11-13 12:40 PST, Adam Roben (:aroben) 		hyatt: review+
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Adam Roben (:aroben)
Comment 1 2009-11-04 09:46:52 PST
<rdar://problem/7214190&7214207>
Adam Roben (:aroben)
Comment 2 2009-11-04 15:58:26 PST
Comment on attachment 42489 [details] Patch After talking with Sam Weinig and John Sullivan, I'm going to first revise our WebKit SPI to use objects to represent worlds instead of unsigned integers. Then I'll redo this patch on top of that change.
Adam Roben (:aroben)
Comment 3 2009-11-13 12:29:57 PST
Created attachment 43190 [details] Tell the WebFrameLoadDelegate when window objects in isolated worlds are cleared
Adam Roben (:aroben)
Comment 4 2009-11-13 12:35:25 PST
Comment on attachment 43190 [details] Tell the WebFrameLoadDelegate when window objects in isolated worlds are cleared Whoops, there's a double ChangeLog in WebKit/win/ChangeLog. Fixed locally.
Adam Roben (:aroben)
Comment 5 2009-11-13 12:40:54 PST
Created attachment 43192 [details] Tell the WebFrameLoadDelegate when window objects in isolated worlds are cleared
Dave Hyatt
Comment 6 2009-11-13 15:25:40 PST
Comment on attachment 43192 [details] Tell the WebFrameLoadDelegate when window objects in isolated worlds are cleared r=me
Adam Roben (:aroben)
Comment 7 2009-11-13 15:49:42 PST
Committed r50973: <http://trac.webkit.org/changeset/50973>
Dimitri Glazkov (Google)
Comment 8 2009-11-13 20:55:56 PST
Chromium port fix landed as: http://trac.webkit.org/changeset/50993. Please have mercy on us Chromium people.
Note You need to log in before you can comment on or make changes to this bug.