Bug 31124

Summary: Tell the WebFrameLoadDelegate when window objects in isolated worlds are cleared
Product: WebKit Reporter: Adam Roben (:aroben) <aroben>
Component: WebKit APIAssignee: Adam Roben (:aroben) <aroben>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, dglazkov, eric, hyatt, sam
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Other   
OS: All   
Bug Depends on: 31414    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Tell the WebFrameLoadDelegate when window objects in isolated worlds are cleared
none
Tell the WebFrameLoadDelegate when window objects in isolated worlds are cleared hyatt: review+

Description Adam Roben (:aroben) 2009-11-04 09:40:13 PST
Created attachment 42489 [details]
Patch

We should tell the WebFrameLoadDelegate when window objects in isolated worlds are cleared so that they can modify the objects as needed.
Comment 1 Adam Roben (:aroben) 2009-11-04 09:46:52 PST
<rdar://problem/7214190&7214207>
Comment 2 Adam Roben (:aroben) 2009-11-04 15:58:26 PST
Comment on attachment 42489 [details]
Patch

After talking with Sam Weinig and John Sullivan, I'm going to first revise our WebKit SPI to use objects to represent worlds instead of unsigned integers. Then I'll redo this patch on top of that change.
Comment 3 Adam Roben (:aroben) 2009-11-13 12:29:57 PST
Created attachment 43190 [details]
Tell the WebFrameLoadDelegate when window objects in isolated worlds are cleared
Comment 4 Adam Roben (:aroben) 2009-11-13 12:35:25 PST
Comment on attachment 43190 [details]
Tell the WebFrameLoadDelegate when window objects in isolated worlds are cleared

Whoops, there's a double ChangeLog in WebKit/win/ChangeLog. Fixed locally.
Comment 5 Adam Roben (:aroben) 2009-11-13 12:40:54 PST
Created attachment 43192 [details]
Tell the WebFrameLoadDelegate when window objects in isolated worlds are cleared
Comment 6 Dave Hyatt 2009-11-13 15:25:40 PST
Comment on attachment 43192 [details]
Tell the WebFrameLoadDelegate when window objects in isolated worlds are cleared

r=me
Comment 7 Adam Roben (:aroben) 2009-11-13 15:49:42 PST
Committed r50973: <http://trac.webkit.org/changeset/50973>
Comment 8 Dimitri Glazkov (Google) 2009-11-13 20:55:56 PST
Chromium port fix landed as: http://trac.webkit.org/changeset/50993.

Please have mercy on us Chromium people.