|Summary:||wrong expected images after Bug 8736|
|Product:||WebKit||Reporter:||Shinichiro Hamaji <hamaji>|
|Component:||Tools / Tests||Assignee:||Nobody <webkit-unassigned>|
|Version:||528+ (Nightly build)|
|OS:||OS X 10.5|
Description Shinichiro Hamaji 2009-11-03 19:21:40 PST
The test HTMLs were updated in Bug 8736 but expected images were not. Please check this commit. http://trac.webkit.org/changeset/44235 The following two expectations are wrong: http://trac.webkit.org/browser/trunk/LayoutTests/fast/borders/border-radius-huge-assert.html http://trac.webkit.org/browser/trunk/LayoutTests/platform/mac/fast/borders/border-radius-huge-assert-expected.png http://trac.webkit.org/browser/trunk/LayoutTests/fast/box-shadow/border-radius-big.html http://trac.webkit.org/browser/trunk/LayoutTests/platform/mac/fast/box-shadow/border-radius-big-expected.png
Comment 2 Alexey Proskuryakov 2009-11-03 23:18:04 PST
Comment on attachment 42442 [details] Patch v1 The patch doesn't include diffs to images. I know this works with svn-create-patch when using Subversion.
Comment 3 Shinichiro Hamaji 2009-11-03 23:37:48 PST
Created attachment 42455 [details] Patch with binary Yeah, I think this is the downside of git... (I guess bugzilla-tool post-commit doesn't create binary patch because we cannot handle git binary patches by svn-apply) Anyway, I re-uploaded the patch using SVN.
Comment 4 Shinichiro Hamaji 2009-11-03 23:51:08 PST
Ah, bugzilla knows how to handle SVN binary patch... OK, from next time, I'll post SVN style patches if my patch contains binaries.
Comment 5 Eric Seidel (no email) 2009-11-05 15:37:52 PST
We really need to fix svn-apply to know how to deal with binary patches. Then we can easily change the one line necessary in scm.py to make bugzilla-tool upload binary patches. http://trac.webkit.org/browser/trunk/WebKitTools/Scripts/modules/scm.py#L452
Comment 6 Eric Seidel (no email) 2009-11-09 17:48:39 PST
Comment on attachment 42455 [details] Patch with binary LGTM.