wrong expected images after Bug 8736

• Component: Tools / Tests
• Status: RESOLVED FIXED

[Shinichiro Hamaji]

The test HTMLs were updated in Bug 8736 but expected images were not. Please check this commit.

http://trac.webkit.org/changeset/44235

The following two expectations are wrong:

http://trac.webkit.org/browser/trunk/LayoutTests/fast/borders/border-radius-huge-assert.html
http://trac.webkit.org/browser/trunk/LayoutTests/platform/mac/fast/borders/border-radius-huge-assert-expected.png
http://trac.webkit.org/browser/trunk/LayoutTests/fast/box-shadow/border-radius-big.html
http://trac.webkit.org/browser/trunk/LayoutTests/platform/mac/fast/box-shadow/border-radius-big-expected.png

[Shinichiro Hamaji]

Created attachment 42442 [details]
Patch v1

[Alexey Proskuryakov]

Comment on attachment 42442 [details]
Patch v1

The patch doesn't include diffs to images. I know this works with svn-create-patch when using Subversion.

[Shinichiro Hamaji]

Created attachment 42455 [details]
Patch with binary

Yeah, I think this is the downside of git... (I guess bugzilla-tool post-commit doesn't create binary patch because we cannot handle git binary patches by svn-apply) Anyway, I re-uploaded the patch using SVN.

[Shinichiro Hamaji]

Ah, bugzilla knows how to handle SVN binary patch... OK, from next time, I'll post SVN style patches if my patch contains binaries.

[Eric Seidel (no email)]

We really need to fix svn-apply to know how to deal with binary patches.  Then we can easily change the one line necessary in scm.py to make bugzilla-tool upload binary patches.
http://trac.webkit.org/browser/trunk/WebKitTools/Scripts/modules/scm.py#L452

[Eric Seidel (no email)]

Comment on attachment 42455 [details]
Patch with binary

LGTM.

[Shinichiro Hamaji]

Committed r50710: <http://trac.webkit.org/changeset/50710>