Bug 31094

Summary:

wrong expected images after Bug 8736

Product:

WebKit

Reporter:

Shinichiro Hamaji <hamaji>

Component:

Tools / Tests

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

eric

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

OS X 10.5

Attachments:

Description	Flags
Patch v1	none
Patch with binary	eric: review+

Shinichiro Hamaji

Reported 2009-11-03 19:21:40 PST

The test HTMLs were updated in Bug 8736 but expected images were not. Please check this commit. http://trac.webkit.org/changeset/44235 The following two expectations are wrong: http://trac.webkit.org/browser/trunk/LayoutTests/fast/borders/border-radius-huge-assert.html http://trac.webkit.org/browser/trunk/LayoutTests/platform/mac/fast/borders/border-radius-huge-assert-expected.png http://trac.webkit.org/browser/trunk/LayoutTests/fast/box-shadow/border-radius-big.html http://trac.webkit.org/browser/trunk/LayoutTests/platform/mac/fast/box-shadow/border-radius-big-expected.png

Attachments
Patch v1 (1.87 KB, patch) 2009-11-03 19:22 PST, Shinichiro Hamaji	no flags	Details Formatted Diff Diff
Patch with binary (63.48 KB, patch) 2009-11-03 23:37 PST, Shinichiro Hamaji	eric: review+	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Shinichiro Hamaji

Comment 1 2009-11-03 19:22:36 PST

Created attachment 42442 [details] Patch v1

Alexey Proskuryakov

Comment 2 2009-11-03 23:18:04 PST

Comment on attachment 42442 [details] Patch v1 The patch doesn't include diffs to images. I know this works with svn-create-patch when using Subversion.

Shinichiro Hamaji

Comment 3 2009-11-03 23:37:48 PST

Created attachment 42455 [details] Patch with binary Yeah, I think this is the downside of git... (I guess bugzilla-tool post-commit doesn't create binary patch because we cannot handle git binary patches by svn-apply) Anyway, I re-uploaded the patch using SVN.

Shinichiro Hamaji

Comment 4 2009-11-03 23:51:08 PST

Ah, bugzilla knows how to handle SVN binary patch... OK, from next time, I'll post SVN style patches if my patch contains binaries.

Eric Seidel (no email)

Comment 5 2009-11-05 15:37:52 PST

We really need to fix svn-apply to know how to deal with binary patches. Then we can easily change the one line necessary in scm.py to make bugzilla-tool upload binary patches. http://trac.webkit.org/browser/trunk/WebKitTools/Scripts/modules/scm.py#L452

Eric Seidel (no email)

Comment 6 2009-11-09 17:48:39 PST

Comment on attachment 42455 [details] Patch with binary LGTM.

Shinichiro Hamaji

Comment 7 2009-11-09 20:09:19 PST

Committed r50710: <http://trac.webkit.org/changeset/50710>

Note You need to log in before you can comment on or make changes to this bug.