Bug 31094

Summary: wrong expected images after Bug 8736
Product: WebKit Reporter: Shinichiro Hamaji <hamaji>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Severity: Normal CC: eric
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Description Flags
Patch v1
Patch with binary eric: review+

Comment 1 Shinichiro Hamaji 2009-11-03 19:22:36 PST
Created attachment 42442 [details]
Patch v1
Comment 2 Alexey Proskuryakov 2009-11-03 23:18:04 PST
Comment on attachment 42442 [details]
Patch v1

The patch doesn't include diffs to images. I know this works with svn-create-patch when using Subversion.
Comment 3 Shinichiro Hamaji 2009-11-03 23:37:48 PST
Created attachment 42455 [details]
Patch with binary

Yeah, I think this is the downside of git... (I guess bugzilla-tool post-commit doesn't create binary patch because we cannot handle git binary patches by svn-apply) Anyway, I re-uploaded the patch using SVN.
Comment 4 Shinichiro Hamaji 2009-11-03 23:51:08 PST
Ah, bugzilla knows how to handle SVN binary patch... OK, from next time, I'll post SVN style patches if my patch contains binaries.
Comment 5 Eric Seidel (no email) 2009-11-05 15:37:52 PST
We really need to fix svn-apply to know how to deal with binary patches.  Then we can easily change the one line necessary in scm.py to make bugzilla-tool upload binary patches.
Comment 6 Eric Seidel (no email) 2009-11-09 17:48:39 PST
Comment on attachment 42455 [details]
Patch with binary

Comment 7 Shinichiro Hamaji 2009-11-09 20:09:19 PST
Committed r50710: <http://trac.webkit.org/changeset/50710>