Bug 31087

Summary:

Web Inspector: Timeline should get information about the paint rectangle.

Product:

WebKit

Reporter:

Kelly Norton <knorton>

Component:

Web Inspector (Deprecated)

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bweinstein, commit-queue, joepeck, keishi, pfeldman, pmuellr, rik, timothy

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
Proposed addition.	timothy: review-, timothy: commit-queue-
Uses IntRect.	none

Kelly Norton

Reported 2009-11-03 14:49:46 PST

In the didPaint callback for the Timeline, we should deliver the dimensions of the paint rectangle.

Attachments
Proposed addition. (4.23 KB, patch) 2009-11-03 14:53 PST, Kelly Norton	timothy: review- timothy: commit-queue-	Details Formatted Diff Diff
Uses IntRect. (4.78 KB, patch) 2009-11-03 19:18 PST, Kelly Norton	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Kelly Norton

Comment 1 2009-11-03 14:53:44 PST

Created attachment 42422 [details] Proposed addition. If this on happens to get r+'d, we probably shouldn't cq+ it quite yet because there are so many other Timeline changes in the cq right now.

Eric Seidel (no email)

Comment 2 2009-11-03 16:29:28 PST

Comment on attachment 42422 [details] Proposed addition. Why wouldn't InspectorTimelineAgent.h use IntRect here?

Kelly Norton

Comment 3 2009-11-03 16:56:40 PST

(In reply to comment #2) > (From update of attachment 42422 [details]) > Why wouldn't InspectorTimelineAgent.h use IntRect here? It definitely could. I was just avoiding the dependency, but I can change that.

Timothy Hatcher

Comment 4 2009-11-03 17:44:34 PST

Comment on attachment 42422 [details] Proposed addition. I agree, use IntRect.

Kelly Norton

Comment 5 2009-11-03 19:18:55 PST

Created attachment 42441 [details] Uses IntRect.

WebKit Commit Bot

Comment 6 2009-11-04 00:42:53 PST

Comment on attachment 42441 [details] Uses IntRect. Clearing flags on attachment: 42441 Committed r50502: <http://trac.webkit.org/changeset/50502>

WebKit Commit Bot

Comment 7 2009-11-04 00:42:57 PST

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.