Bug 31065

Summary:

Web Inspector: Timeline should show resources loading.

Product:

WebKit

Reporter:

Kelly Norton <knorton>

Component:

Web Inspector (Deprecated)

Assignee:

Kelly Norton <knorton>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bweinstein, commit-queue, joepeck, keishi, pfeldman, pmuellr, rik, timothy

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
Proposed implementation for resources in the timeline.	none
Fixes some issues.	timothy: review+, timothy: commit-queue-
Updates and resolves the conflicts.	none

Kelly Norton

Reported 2009-11-03 09:24:58 PST

The default resource tracking has more overhead than is necessary, so the plan is to just add lighter weight callbacks to InspectorTimelineAgent with just enough information to display a pill box on the timeline. If resource tracking is enabled, the UI can use the identifier to cross-link to give users more detail about a particular resource. (cleaning up a patch now)

Attachments
Proposed implementation for resources in the timeline. (11.43 KB, patch) 2009-11-03 12:28 PST, Kelly Norton	no flags	Details Formatted Diff Diff
Fixes some issues. (11.47 KB, patch) 2009-11-03 13:26 PST, Kelly Norton	timothy: review+ timothy: commit-queue-	Details Formatted Diff Diff
Updates and resolves the conflicts. (12.04 KB, patch) 2009-11-04 08:43 PST, Kelly Norton	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Kelly Norton

Comment 1 2009-11-03 12:28:14 PST

Created attachment 42404 [details] Proposed implementation for resources in the timeline. Let me know what you guys think of this approach.

Kelly Norton

Comment 2 2009-11-03 13:26:55 PST

Created attachment 42412 [details] Fixes some issues.

Timothy Hatcher

Comment 3 2009-11-03 17:50:39 PST

Comment on attachment 42412 [details] Fixes some issues. I'll land this, since TimelineAgent.js will conflict with another cq+ change.

Kelly Norton

Comment 4 2009-11-04 08:43:11 PST

Created attachment 42485 [details] Updates and resolves the conflicts.

WebKit Commit Bot

Comment 5 2009-11-04 09:17:22 PST

Comment on attachment 42485 [details] Updates and resolves the conflicts. Clearing flags on attachment: 42485 Committed r50515: <http://trac.webkit.org/changeset/50515>

WebKit Commit Bot

Comment 6 2009-11-04 09:17:26 PST

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.