Bug 31052

Summary: Web Inspector: Prepare for heap profiles upstreaming
Product: WebKit Reporter: Mikhail Naganov <mnaganov>
Component: Web Inspector (Deprecated)Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: apavlov, commit-queue, pfeldman, timothy
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
proposed change
pfeldman: review-
proposed change, comments addressed none

Description Mikhail Naganov 2009-11-03 04:55:25 PST 
Add new functionality by deleting some code ;)

- pass profile type id from InspectorController;
- this makes WebInspector.CPUProfile redundant---removed;
- support multiple profile types when populating profiles.
Comment 1 Mikhail Naganov 2009-11-03 04:57:13 PST 
Created attachment 42367 [details]
proposed change
Comment 2 Pavel Feldman 2009-11-03 06:34:22 PST 
Comment on attachment 42367 [details]
proposed change

> -    this.panels.profiles.addProfileHeader(WebInspector.CPUProfileType.TypeId, new WebInspector.CPUProfile(profile));
> +    this.panels.profiles.addProfileHeader(profile.typeId, profile);

If every profile has typeId from now on, should we pass single argument here?
Comment 3 Mikhail Naganov 2009-11-03 06:55:56 PST 
Created attachment 42378 [details]
proposed change, comments addressed
Comment 4 WebKit Commit Bot 2009-11-03 09:47:48 PST 
Comment on attachment 42378 [details]
proposed change, comments addressed

Clearing flags on attachment: 42378

Committed r50460: <http://trac.webkit.org/changeset/50460>
Comment 5 WebKit Commit Bot 2009-11-03 09:47:52 PST 
All reviewed patches have been landed.  Closing bug.