Bug 31041

Summary:

Improve SecurityOrigin::toString comment

Product:

WebKit

Reporter:

Adam Barth <abarth>

Component:

Tools / Tests

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, fishd

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
Patch	fishd: review+
remove )	none

Adam Barth

Reported 2009-11-02 20:33:14 PST

This comment confused fishd today. Let's make it better. Patch forthcoming.

Attachments
Patch (1.94 KB, patch) 2009-11-02 20:49 PST, Adam Barth	fishd: review+	Details Formatted Diff Diff
remove ) (1.68 KB, patch) 2009-11-12 18:27 PST, Adam Barth	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Adam Barth

Comment 1 2009-11-02 20:49:09 PST

Created attachment 42357 [details] Patch

Darin Fisher (:fishd, Google)

Comment 2 2009-11-02 21:28:21 PST

Comment on attachment 42357 [details] Patch r=me, thanks!! > Index: WebCore/page/SecurityOrigin.h ... > + // shouldTreatURLSchemeAsNoAccess). nit: no trailing ')'

Adam Barth

Comment 3 2009-11-02 21:30:04 PST

(In reply to comment #2) > (From update of attachment 42357 [details]) > r=me, thanks!! > > > Index: WebCore/page/SecurityOrigin.h > ... > > + // shouldTreatURLSchemeAsNoAccess). > > nit: no trailing ')' Ah. Left over editing crud.

Adam Barth

Comment 4 2009-11-12 18:27:44 PST

Created attachment 43123 [details] remove )

WebKit Commit Bot

Comment 5 2009-11-12 19:05:50 PST

Comment on attachment 43123 [details] remove ) Clearing flags on attachment: 43123 Committed r50924: <http://trac.webkit.org/changeset/50924>

WebKit Commit Bot

Comment 6 2009-11-12 19:05:55 PST

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.