Bug 31041

Summary: Improve SecurityOrigin::toString comment
Product: WebKit Reporter: Adam Barth <abarth>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, fishd
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
fishd: review+
remove ) none

Description Adam Barth 2009-11-02 20:33:14 PST
This comment confused fishd today.  Let's make it better.  Patch forthcoming.
Comment 1 Adam Barth 2009-11-02 20:49:09 PST
Created attachment 42357 [details]
Patch
Comment 2 Darin Fisher (:fishd, Google) 2009-11-02 21:28:21 PST
Comment on attachment 42357 [details]
Patch

r=me, thanks!!

> Index: WebCore/page/SecurityOrigin.h
...
> +        // shouldTreatURLSchemeAsNoAccess).

nit: no trailing ')'
Comment 3 Adam Barth 2009-11-02 21:30:04 PST
(In reply to comment #2)
> (From update of attachment 42357 [details])
> r=me, thanks!!
> 
> > Index: WebCore/page/SecurityOrigin.h
> ...
> > +        // shouldTreatURLSchemeAsNoAccess).
> 
> nit: no trailing ')'

Ah.  Left over editing crud.
Comment 4 Adam Barth 2009-11-12 18:27:44 PST
Created attachment 43123 [details]
remove )
Comment 5 WebKit Commit Bot 2009-11-12 19:05:50 PST
Comment on attachment 43123 [details]
remove )

Clearing flags on attachment: 43123

Committed r50924: <http://trac.webkit.org/changeset/50924>
Comment 6 WebKit Commit Bot 2009-11-12 19:05:55 PST
All reviewed patches have been landed.  Closing bug.