Bug 31041 - Improve SecurityOrigin::toString comment
Summary: Improve SecurityOrigin::toString comment
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-11-02 20:33 PST by Adam Barth
Modified: 2009-11-12 19:05 PST (History)
2 users (show)

See Also:


Attachments
Patch (1.94 KB, patch)
2009-11-02 20:49 PST, Adam Barth
fishd: review+
Details | Formatted Diff | Diff
remove ) (1.68 KB, patch)
2009-11-12 18:27 PST, Adam Barth
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Barth 2009-11-02 20:33:14 PST
This comment confused fishd today.  Let's make it better.  Patch forthcoming.
Comment 1 Adam Barth 2009-11-02 20:49:09 PST
Created attachment 42357 [details]
Patch
Comment 2 Darin Fisher (:fishd, Google) 2009-11-02 21:28:21 PST
Comment on attachment 42357 [details]
Patch

r=me, thanks!!

> Index: WebCore/page/SecurityOrigin.h
...
> +        // shouldTreatURLSchemeAsNoAccess).

nit: no trailing ')'
Comment 3 Adam Barth 2009-11-02 21:30:04 PST
(In reply to comment #2)
> (From update of attachment 42357 [details])
> r=me, thanks!!
> 
> > Index: WebCore/page/SecurityOrigin.h
> ...
> > +        // shouldTreatURLSchemeAsNoAccess).
> 
> nit: no trailing ')'

Ah.  Left over editing crud.
Comment 4 Adam Barth 2009-11-12 18:27:44 PST
Created attachment 43123 [details]
remove )
Comment 5 WebKit Commit Bot 2009-11-12 19:05:50 PST
Comment on attachment 43123 [details]
remove )

Clearing flags on attachment: 43123

Committed r50924: <http://trac.webkit.org/changeset/50924>
Comment 6 WebKit Commit Bot 2009-11-12 19:05:55 PST
All reviewed patches have been landed.  Closing bug.