| Summary: | committers.py needs a way to store non-bugzilla email addresses | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Eric Seidel (no email) <eric> | ||||||||
| Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | abarth, commit-queue, levin | ||||||||
| Priority: | P2 | ||||||||||
| Version: | 528+ (Nightly build) | ||||||||||
| Hardware: | PC | ||||||||||
| OS: | OS X 10.5 | ||||||||||
| Bug Depends on: | |||||||||||
| Bug Blocks: | 30970 | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Eric Seidel (no email)
2009-11-02 17:56:38 PST
Created attachment 42353 [details] Add code to support bug 30970 Created attachment 42354 [details] Add code to support bug 30970 IMO we should be treating the address used for committing as the “real” address, not the Bugzilla one. I think it might make sense to just make all email addresses equal. I think I'll change it to be one flat list instead of having a special separate bugzilla email address. As long as it's impossible to create an account with bugzilla that points to an email address you don't own, then having a flat list should work just fine. I think I'll make it a flat list of emails, and possibly will have a separate flat list for expired emails. Expired emails may not be necessary for active contributers, I'm not sure. If I ever end up landing the rest of bug 26533 then we'll need more storage options for committers.py. Created attachment 42414 [details]
Updated patch. Flattened emails into one list.
Comment on attachment 42414 [details]
Updated patch. Flattened emails into one list.
The zeroth email is still special, but other than that this looks good. Maybe consider__str__ listing all the emails?
I had __str__ listing all the emails in a previous draft and it looked strange. I agree, the 0th email shouldn't really be special. but __str__ is just supposed to give you some idea what the record is, and it not really meant to be a full serialization of the object. I think it's OK for 0 to be "special" in this way for now. I'm sad that this patch looses the data of what email addresses are valid bugzilla addresses, but I don't think we really need that information. If we later need it, it will be easy to re-acquire with a little scripting. Thanks for the review. Comment on attachment 42414 [details] Updated patch. Flattened emails into one list. Clearing flags on attachment: 42414 Committed r50505: <http://trac.webkit.org/changeset/50505> All reviewed patches have been landed. Closing bug. |