Bug 31030

Summary: Web Inspector: Timeline instrumentation for Node::dispatchGenericEvent missed a case.
Product: WebKit Reporter: Kelly Norton <knorton>
Component: Web Inspector (Deprecated)Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: bweinstein, commit-queue, joepeck, keishi, pfeldman, pmuellr, rik, timothy
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Proposed fix. none

Kelly Norton
Reported 2009-11-02 13:35:17 PST
This one is my bad. When I filtered out events with no listeners, I forgot to add support for DOMWindow dispatch. This only effects DOM events that are delivered to window (like 'click'). So we current miss this case: window.addEventListener('click', function(e) { }, false); Patch is ready, I'm about to upload.
Attachments
Proposed fix. (2.63 KB, patch)
2009-11-02 13:42 PST, Kelly Norton
no flags
Kelly Norton
Comment 1 2009-11-02 13:42:50 PST
Created attachment 42340 [details] Proposed fix.
WebKit Commit Bot
Comment 2 2009-11-02 14:02:40 PST
Comment on attachment 42340 [details] Proposed fix. Clearing flags on attachment: 42340 Committed r50428: <http://trac.webkit.org/changeset/50428>
WebKit Commit Bot
Comment 3 2009-11-02 14:02:44 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.