Bug 310290
| Summary: | Remove CSSToLengthConversionData::computedLineHeightForFontUnits | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Vitor Roriz <vitor.roriz> |
| Component: | CSS | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | cdumez, koivisto, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Vitor Roriz
The only call site for computedLineHeightForFontUnits is in the lh unit resolution else branch, which is only reached when \!computingFontSize(). This means the computingFontSize() branch inside computedLineHeightForFontUnits is dead code, and the method always reduces to style()->computedLineHeight(). Therefore, we can call that directly and remove computedLineHeightForFontUnits.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/172928233>
Vitor Roriz
Pull request: https://github.com/WebKit/WebKit/pull/60944
EWS
Committed 309569@main (db430c54ab45): <https://commits.webkit.org/309569@main>
Reviewed commits have been landed. Closing PR #60944 and removing active labels.