Bug 31026

Summary:

[cairo] Remove old workaround from pre-CAIRO_EXTEND_PAD days

Product:

WebKit

Reporter:

Benjamin Otte <otte>

Component:

Platform

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED DUPLICATE

Severity:

Normal

CC:

bfulgham, jmalonzo, krit

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

All

Attachments:

Description	Flags
patch	otte: review-

Benjamin Otte

Reported 2009-11-02 12:06:05 PST

Back when CAIRO_EXTEND_PAD was not implemented the code used CAIRO_FILTER_NEAREST to avoid a gradient effect at image borders. This patch uses CAIRO_EXTEND_PAD and restores bilinear scaling for images. It also bumps the required Cairo version to 1.6 as CAIRO_EXTEND_PAD was implemented there. https://bugs.webkit.org/show_bug.cgi?id=14017

Attachments
patch (3.03 KB, patch) 2009-11-02 12:30 PST, Benjamin Otte	otte: review-	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Benjamin Otte

Comment 1 2009-11-02 12:30:46 PST

Created attachment 42335 [details] patch

Dirk Schulze

Comment 2 2009-11-03 02:28:08 PST

If you(In reply to comment #1) > Created an attachment (id=42335) [details] > patch If you force Cairo 1.6 as minimum, you could delete the #ifdefs in PathCairo and GraphicsContextCairo as well. And I thnk that we use the webkit coding style on the cairo bits too. So no break between cairo_pattern_set_extend and the brace. I also think that this is a duplication of bug 19266 , right?

Benjamin Otte

Comment 3 2009-11-03 02:49:35 PST

(In reply to comment #2) > If you force Cairo 1.6 as minimum, you could delete the #ifdefs in PathCairo > and GraphicsContextCairo as well. And I thnk that we use the webkit coding > style on the cairo bits too. So no break between cairo_pattern_set_extend and > the brace. I also think that this is a duplication of bug 19266 , right? > Will do, will fix, yes. *** This bug has been marked as a duplicate of bug 19266 ***

Note You need to log in before you can comment on or make changes to this bug.