Bug 31025

Summary:

Installation of GIR files doesn't respect --prefix option

Product:

WebKit

Reporter:

Estêvão Samuel Procópio Amaral <tevaum>

Component:

WebKit Misc.

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

OS X 10.5

Attachments:

Description	Flags
Patch to use --prefix path in GITDIR and GITTYPELIBDIR	gustavo: review-
Tabless patch to use --prefix path in GITDIR and GITTYPELIBDIR	none
Patch to use --prefix path in GITDIR and GITTYPELIBDIR	none

Estêvão Samuel Procópio Amaral

Reported 2009-11-02 11:54:32 PST

When you build WebKit with --prefix=/som/path and --enable-introspection, the configure.ac file doesn't use the defined prefix path when asking pkg-config for the path of GIRDIR and GIRTYPELIBDIR.

Attachments
Patch to use --prefix path in GITDIR and GITTYPELIBDIR (1.40 KB, patch) 2009-11-02 11:57 PST, Estêvão Samuel Procópio Amaral	gustavo: review-	Details Formatted Diff Diff
Tabless patch to use --prefix path in GITDIR and GITTYPELIBDIR (1.40 KB, patch) 2009-11-02 13:48 PST, Estêvão Samuel Procópio Amaral	no flags	Details Formatted Diff Diff
Patch to use --prefix path in GITDIR and GITTYPELIBDIR (1.49 KB, patch) 2009-11-02 14:12 PST, Estêvão Samuel Procópio Amaral	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Estêvão Samuel Procópio Amaral

Comment 1 2009-11-02 11:57:24 PST

Created attachment 42331 [details] Patch to use --prefix path in GITDIR and GITTYPELIBDIR

Gustavo Noronha (kov)

Comment 2 2009-11-02 13:42:36 PST

Comment on attachment 42331 [details] Patch to use --prefix path in GITDIR and GITTYPELIBDIR > + Reviewed by NOBODY (OOPS!). > + > + Bug 31025 - make install wasn't respecting --prefix option for gobject- > + introspection files. (https://bugs.webkit.org/show_bug.cgi?id=31025) There seems to be a tab here. Only spaces are allowed. If you're using emacs select this paragraph and do a M-x untabity, please =).

Estêvão Samuel Procópio Amaral

Comment 3 2009-11-02 13:48:43 PST

Created attachment 42341 [details] Tabless patch to use --prefix path in GITDIR and GITTYPELIBDIR Tabs removed from ChangeLog

Estêvão Samuel Procópio Amaral

Comment 4 2009-11-02 14:12:10 PST

Created attachment 42343 [details] Patch to use --prefix path in GITDIR and GITTYPELIBDIR Adjusting ChangeLog to meet WebKit converntion

Gustavo Noronha (kov)

Comment 5 2009-11-02 14:13:27 PST

Comment on attachment 42343 [details] Patch to use --prefix path in GITDIR and GITTYPELIBDIR Thanks for the patch.

WebKit Commit Bot

Comment 6 2009-11-02 14:26:08 PST

Comment on attachment 42343 [details] Patch to use --prefix path in GITDIR and GITTYPELIBDIR Clearing flags on attachment: 42343 Committed r50430: <http://trac.webkit.org/changeset/50430>

WebKit Commit Bot

Comment 7 2009-11-02 14:26:12 PST

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.