Bug 31017

Summary: media/video-currentTime-set.html uses too short of a timeout
Product: WebKit Reporter: Andrew Scherkus <scherkus>
Component: MediaAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, eric.carlson
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Attachments:
Description Flags
Round 1
none
Round 1 + Better ChangeLog none

Andrew Scherkus
Reported 2009-11-02 10:15:48 PST
Eric and I discussed in #webkit a while back that some tests use too short of a timeout and end the test too early. This would be one of them :) I'm sure there are more, but verifying that the cause of flaky test failures is indeed a timeout and not some other bug is a tricky and time consuming process.
Attachments
Round 1 (1.24 KB, patch)
2009-11-02 10:17 PST, Andrew Scherkus 		no flags
DetailsFormatted DiffDiff
Round 1 + Better ChangeLog (1.36 KB, patch)
2009-11-02 10:19 PST, Andrew Scherkus 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Andrew Scherkus
Comment 1 2009-11-02 10:17:14 PST
Created attachment 42323 [details] Round 1
Andrew Scherkus
Comment 2 2009-11-02 10:19:23 PST
Created attachment 42324 [details] Round 1 + Better ChangeLog Forgot to mention the call to logResult() was fixed.
Eric Carlson
Comment 3 2009-11-02 10:34:34 PST
Comment on attachment 42324 [details] Round 1 + Better ChangeLog r=me
WebKit Commit Bot
Comment 4 2009-11-02 10:53:06 PST
Comment on attachment 42324 [details] Round 1 + Better ChangeLog Clearing flags on attachment: 42324 Committed r50420: <http://trac.webkit.org/changeset/50420>
WebKit Commit Bot
Comment 5 2009-11-02 10:53:11 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.