Bug 31002

Summary:

Web Inspector: Add support for window events to Timeline.

Product:

WebKit

Reporter:

Kelly Norton <knorton>

Component:

Web Inspector (Deprecated)

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bweinstein, eric, joepeck, keishi, pfeldman, pmuellr, rik, timothy

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
Proposed change.	none
Merged window and dom events to the same callbacks.	timothy: review-
Adds missing change to localizedStrings.js	timothy: review-
w/ binary diff.	timothy: review+, commit-queue: commit-queue-

Kelly Norton

Reported 2009-11-01 19:40:59 PST

Good to see things like onresize on the timeline. patch coming.

Attachments
Proposed change. (8.35 KB, patch) 2009-11-01 19:54 PST, Kelly Norton	no flags	Details Formatted Diff Diff
Merged window and dom events to the same callbacks. (11.06 KB, patch) 2009-11-01 20:32 PST, Kelly Norton	timothy: review-	Details Formatted Diff Diff
Adds missing change to localizedStrings.js (11.30 KB, patch) 2009-11-01 20:43 PST, Kelly Norton	timothy: review-	Details Formatted Diff Diff
w/ binary diff. (11.44 KB, patch) 2009-11-01 20:53 PST, Kelly Norton	timothy: review+ commit-queue: commit-queue-	Details Formatted Diff Diff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.

Kelly Norton

Comment 1 2009-11-01 19:54:16 PST

Created attachment 42291 [details] Proposed change.

Kelly Norton

Comment 2 2009-11-01 20:32:34 PST

Created attachment 42292 [details] Merged window and dom events to the same callbacks.

Timothy Hatcher

Comment 3 2009-11-01 20:39:23 PST

Comment on attachment 42292 [details] Merged window and dom events to the same callbacks. You need to update localizableStrings.js for the DOM Event => Event string change. Otherwise r+.

Kelly Norton

Comment 4 2009-11-01 20:43:08 PST

Created attachment 42294 [details] Adds missing change to localizedStrings.js

Timothy Hatcher

Comment 5 2009-11-01 20:49:59 PST

Comment on attachment 42294 [details] Adds missing change to localizedStrings.js Need to binary diff for localizableStrings.js.

Kelly Norton

Comment 6 2009-11-01 20:53:05 PST

Created attachment 42295 [details] w/ binary diff.

WebKit Commit Bot

Comment 7 2009-11-01 22:18:06 PST

Comment on attachment 42295 [details] w/ binary diff. Rejecting patch 42295 from commit-queue. Failed to run "['/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/svn-apply', '--reviewer', 'Timothy Hatcher', '--force']" exit_code: 2 Last 500 characters of output: ile WebCore/ChangeLog patch: **** Only garbage was found in the patch input. patching file WebCore/dom/Node.cpp patching file WebCore/inspector/InspectorTimelineAgent.cpp patching file WebCore/inspector/InspectorTimelineAgent.h patching file WebCore/inspector/TimelineRecordFactory.cpp patching file WebCore/inspector/TimelineRecordFactory.h patching file WebCore/inspector/front-end/TimelineAgent.js patching file WebCore/inspector/front-end/TimelinePanel.js patching file WebCore/page/DOMWindow.cpp

Pavel Feldman

Comment 8 2009-11-02 01:37:51 PST

Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebCore/ChangeLog M WebCore/English.lproj/localizedStrings.js M WebCore/dom/Node.cpp M WebCore/inspector/InspectorTimelineAgent.cpp M WebCore/inspector/InspectorTimelineAgent.h M WebCore/inspector/TimelineRecordFactory.cpp M WebCore/inspector/TimelineRecordFactory.h M WebCore/inspector/front-end/TimelineAgent.js M WebCore/inspector/front-end/TimelinePanel.js M WebCore/page/DOMWindow.cpp Committed r50407

Eric Seidel (no email)

Comment 9 2009-11-03 09:41:39 PST

I believe you hit bug 26830.

Note You need to log in before you can comment on or make changes to this bug.