Bug 30986

Summary: Fix layering violations in GraphicsContext3D
Product: WebKit Reporter: Oliver Hunt <oliver>
Component: Layout and RenderingAssignee: Oliver Hunt <oliver>
Status: NEW ---    
Severity: Normal CC: cmarrin
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Attachments:
Description Flags
Remove canvas and image element uses from CanvasRenderingContext3D
none
Remove canvas and image element uses from CanvasRenderingContext3D none

Description Oliver Hunt 2009-10-31 20:36:42 PDT
There are multiple uses of DOM objects in the GraphicsContext3D object which are a significant layering violation.  These need to be fixed.
Comment 1 Oliver Hunt 2009-10-31 21:36:00 PDT
Created attachment 42266 [details]
Remove canvas and image element uses from CanvasRenderingContext3D
Comment 2 Oliver Hunt 2009-10-31 21:37:55 PDT
Created attachment 42267 [details]
Remove canvas and image element uses from CanvasRenderingContext3D
Comment 3 Darin Adler 2009-11-01 13:18:17 PST
Comment on attachment 42267 [details]
Remove canvas and image element uses from CanvasRenderingContext3D

> +    CachedImage* cachedImage = image->cachedImage();
> +    if (!cachedImage)
> +        return;
> +    m_context->texSubImage2D(target, level, xoffset, yoffset, width, height, cachedImage->image(), flipY, premultiplyAlpha);
>      cleanupAfterGraphicsCall(false);

All the other cases you put a blank line after the early return.

r=me
Comment 4 Oliver Hunt 2009-11-01 18:10:36 PST
Committed r50394