Bug 30983

Summary: Remove obsolete null checks from CanvasRenderingContext3DMac
Product: WebKit Reporter: Oliver Hunt <oliver>
Component: DOMAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Attachments:
Description Flags
Patch
none
Patch darin: review+

Oliver Hunt
Reported 2009-10-31 15:47:46 PDT
As part of my canvas refactoring a large number of null checks in CanvasRenderingContext3DMac become obsolete
Attachments
Patch (6.93 KB, patch)
2009-10-31 15:48 PDT, Oliver Hunt 		no flags
DetailsFormatted DiffDiff
Patch (6.95 KB, patch)
2009-10-31 15:58 PDT, Oliver Hunt 		darin: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Oliver Hunt
Comment 1 2009-10-31 15:48:43 PDT
Created attachment 42261 [details] Patch
Darin Adler
Comment 2 2009-10-31 15:54:38 PDT
Comment on attachment 42261 [details] Patch > + ASSERT(program && shader); We should always use multiple assertions instead of an && in an assertion, because that way we can tell which one fails. The title of this bug does not match the patch. The patch does not remove assertions. It adds assertions and removes unneeded runtime checks. review- because although the problems with the patch are extremely minor, the benefit of the patch is also minor Please fix the title and don't use && in assertions.
Oliver Hunt
Comment 3 2009-10-31 15:57:32 PDT
Whoops, yes i am removing null checks :D
Oliver Hunt
Comment 4 2009-10-31 15:58:20 PDT
Created attachment 42262 [details] Patch
Oliver Hunt
Comment 5 2009-10-31 16:22:51 PDT
Committed r50382
Note You need to log in before you can comment on or make changes to this bug.