| Summary: | Remove obsolete null checks from CanvasRenderingContext3DMac | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Oliver Hunt <oliver> | ||||||
| Component: | DOM | Assignee: | Nobody <webkit-unassigned> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | ||||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | PC | ||||||||
| OS: | OS X 10.5 | ||||||||
| Attachments: |
|
||||||||
|
Description
Oliver Hunt
2009-10-31 15:47:46 PDT
Created attachment 42261 [details]
Patch
Comment on attachment 42261 [details] Patch > + ASSERT(program && shader); We should always use multiple assertions instead of an && in an assertion, because that way we can tell which one fails. The title of this bug does not match the patch. The patch does not remove assertions. It adds assertions and removes unneeded runtime checks. review- because although the problems with the patch are extremely minor, the benefit of the patch is also minor Please fix the title and don't use && in assertions. Whoops, yes i am removing null checks :D Created attachment 42262 [details]
Patch
|