Bug 30967

Summary:

Give the FrameLoaderClient the ability to override Settings::isJavaScriptEnabled.

Product:

WebKit

Reporter:

Darin Fisher (:fishd, Google) <fishd>

Component:

Platform

Assignee:

Darin Fisher (:fishd, Google) <fishd>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
v1 patch	darin: review+, fishd: commit-queue-
v2 patch	abarth: review+, fishd: commit-queue-

Darin Fisher (:fishd, Google)

Reported 2009-10-30 15:22:33 PDT

Give the FrameLoaderClient the ability to override Settings::isJavaScriptEnabled. I plan to use this to remove ChromiumBridge::uiResourceProtocol() as well as some other application-specific cruft in V8Proxy.cpp.

Attachments
v1 patch (4.01 KB, patch) 2009-10-30 15:23 PDT, Darin Fisher (:fishd, Google)	darin: review+ fishd: commit-queue-	Details Formatted Diff Diff
v2 patch (5.95 KB, patch) 2009-10-30 15:35 PDT, Darin Fisher (:fishd, Google)	abarth: review+ fishd: commit-queue-	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Darin Fisher (:fishd, Google)

Comment 1 2009-10-30 15:23:55 PDT

Created attachment 42239 [details] v1 patch

Adam Barth

Comment 2 2009-10-30 15:29:06 PDT

This looks great, but can't we just delete V8Proxy::isEnabled? V8Proxy and ScriptContoller are the same thing.

Darin Fisher (:fishd, Google)

Comment 3 2009-10-30 15:31:43 PDT

Yes, I can do that. I can also remove uiResourceProtocol from ChromiumBridge!

Darin Adler

Comment 4 2009-10-30 15:32:41 PDT

Comment on attachment 42239 [details] v1 patch Looks OK. r=me

Darin Fisher (:fishd, Google)

Comment 5 2009-10-30 15:35:24 PDT

Created attachment 42240 [details] v2 patch

Adam Barth

Comment 6 2009-10-30 16:49:25 PDT

Comment on attachment 42240 [details] v2 patch Great! I like how this patch makes the old code look silly.

Darin Fisher (:fishd, Google)

Comment 7 2009-11-02 21:47:58 PST

Landed as: http://trac.webkit.org/changeset/50441

Note You need to log in before you can comment on or make changes to this bug.