Bug 30948

Summary: Regression: crash enumerating properties of an object with getters or setters
Product: WebKit Reporter: Oliver Hunt <oliver>
Component: JavaScriptCoreAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Attachments:
Description Flags
Patch v1 barraclough: review+

Description Oliver Hunt 2009-10-30 00:54:19 PDT 
Code inspection showed that enumeration caching doesn't account for the existence of getters or setters.
Comment 1 Oliver Hunt 2009-10-30 01:03:35 PDT 
Created attachment 42180 [details]
Patch v1
Comment 2 Gavin Barraclough 2009-10-30 01:10:36 PDT 
Comment on attachment 42180 [details]
Patch v1

In the über-big if statement, I have a feeling we usually put the && on the continuing line.  Also, might be nicer with one line per clause.
Still, r+ with or without that change.
Comment 3 Oliver Hunt 2009-10-30 01:13:54 PDT 
Committed r50323
Comment 4 Oliver Hunt 2009-10-30 02:15:09 PDT 
Committed r50323