Bug 30948

Summary: Regression: crash enumerating properties of an object with getters or setters
Product: WebKit Reporter: Oliver Hunt <oliver>
Component: JavaScriptCoreAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Attachments:
Description Flags
Patch v1 barraclough: review+

Oliver Hunt
Reported 2009-10-30 00:54:19 PDT
Code inspection showed that enumeration caching doesn't account for the existence of getters or setters.
Attachments
Patch v1 (3.83 KB, patch)
2009-10-30 01:03 PDT, Oliver Hunt 		barraclough: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Oliver Hunt
Comment 1 2009-10-30 01:03:35 PDT
Created attachment 42180 [details] Patch v1
Gavin Barraclough
Comment 2 2009-10-30 01:10:36 PDT
Comment on attachment 42180 [details] Patch v1 In the über-big if statement, I have a feeling we usually put the && on the continuing line. Also, might be nicer with one line per clause. Still, r+ with or without that change.
Oliver Hunt
Comment 3 2009-10-30 01:13:54 PDT
Committed r50323
Oliver Hunt
Comment 4 2009-10-30 02:15:09 PDT
Committed r50323
Note You need to log in before you can comment on or make changes to this bug.