Bug 30943

Summary: [V8] More cleanup after r49949: remove ListenerGuard.
Product: WebKit Reporter: Dmitry Titov <dimich>
Component: WebCore JavaScriptAssignee: Dmitry Titov <dimich>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, dglazkov
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Proposed patch. dglazkov: review+, dimich: commit-queue-

Dmitry Titov
Reported 2009-10-29 19:16:41 PDT
This is remaining cleanup after http://trac.webkit.org/changeset/49949. Since EventListeners are now independent of Frame or V8 context, there is no need to have ListenerGuard that was disabling listeners on window close or navigation. This enables fast/events/add-event-without-document.html for Chromium. Run the change through Chromium trybots.
Attachments
Proposed patch. (20.72 KB, patch)
2009-10-29 19:21 PDT, Dmitry Titov 		dglazkov: review+
dimich: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Dmitry Titov
Comment 1 2009-10-29 19:21:18 PDT
Created attachment 42170 [details] Proposed patch. Trybot run completed successfully.
Dimitri Glazkov (Google)
Comment 2 2009-10-29 20:38:22 PDT
Comment on attachment 42170 [details] Proposed patch. r=me. Gorgeous. Thanks for cleaning up what I should've cleaned up in the first place.
Dmitry Titov
Comment 3 2009-10-30 13:13:57 PDT
Landed: http://trac.webkit.org/changeset/50347
Note You need to log in before you can comment on or make changes to this bug.