Bug 30939

Summary: counterValueForElementById should return space-separated string for multiple counters
Product: WebKit Reporter: Shinichiro Hamaji <hamaji>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Attachments:
Description Flags
Patch v1 darin: review+

Shinichiro Hamaji
Reported 2009-10-29 18:34:10 PDT
As Darin suggested in Bug 30555, layoutTestController.counterValueForElementById should return space-separated string when there are multiple counters in one element.
Attachments
Patch v1 (6.56 KB, patch)
2009-10-29 18:35 PDT, Shinichiro Hamaji 		darin: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Shinichiro Hamaji
Comment 1 2009-10-29 18:35:57 PDT
Created attachment 42165 [details] Patch v1
Darin Adler
Comment 2 2009-10-30 10:14:42 PDT
Comment on attachment 42165 [details] Patch v1 > + stream << " "; It's probably more efficient to append a space character instead of a single-character string, but efficiency is not critical here. r=me
Shinichiro Hamaji
Comment 3 2009-10-30 10:32:45 PDT
> It's probably more efficient to append a space character instead of a > single-character string, but efficiency is not critical here. Yeah, I considered it a bit, but I just used the C string because I couldn't find operator<<(char) in TextStream. I think it's not worth adding an overload function.
Shinichiro Hamaji
Comment 4 2009-10-30 10:58:19 PDT
Committed r50345: <http://trac.webkit.org/changeset/50345>
Note You need to log in before you can comment on or make changes to this bug.